Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix export bindings not updated by 'for ... in' and 'for ... of' #11074

Merged
merged 13 commits into from Feb 9, 2020
Merged

Fix export bindings not updated by 'for ... in' and 'for ... of' #11074

merged 13 commits into from Feb 9, 2020

Commits on Jan 31, 2020

  1. Correctly transpile export bindings for some for-of loops

    @vedantroy
    vedantroy committed Jan 31, 2020
    Copy the full SHA
    2b7da10 View commit details
    Browse the repository at this point in the history

  2. Correctly transform non-destructured for of loops to update exported … 

    …variables
    @vedantroy
    vedantroy committed Jan 31, 2020
    Copy the full SHA
    f51494d View commit details
    Browse the repository at this point in the history

  3. Add tests

    @vedantroy
    vedantroy committed Jan 31, 2020
    Copy the full SHA
    f61009c View commit details
    Browse the repository at this point in the history

  4. Don't replace entire for of loop

    @vedantroy
    vedantroy committed Jan 31, 2020
    Copy the full SHA
    998a477 View commit details
    Browse the repository at this point in the history

  5. Correctly transform destructured for-of/for-in exports

    @vedantroy
    vedantroy committed Jan 31, 2020
    Copy the full SHA
    ec006f4 View commit details
    Browse the repository at this point in the history

  6. Update exported variables in array pattern and more fixes

    @vedantroy
    vedantroy committed Jan 31, 2020
    Copy the full SHA
    7be543a View commit details
    Browse the repository at this point in the history

  7. Refresh test output

    @vedantroy
    vedantroy committed Jan 31, 2020
    Copy the full SHA
    5bdbe28 View commit details
    Browse the repository at this point in the history

  8. Update tests and rebase on master

    @vedantroy
    vedantroy committed Jan 31, 2020
    Copy the full SHA
    794f6f3 View commit details
    Browse the repository at this point in the history

  9. Refactor ForOf|ForIn visitor

    @vedantroy
    vedantroy committed Jan 31, 2020
    Copy the full SHA
    949d2f6 View commit details
    Browse the repository at this point in the history

  10. Don't transform re-declared exported vars

    @vedantroy
    vedantroy committed Jan 31, 2020
    Copy the full SHA
    468e9ed View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2020

  1. Generate better name for loop id 

    Co-Authored-By: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @vedantroy @nicolo-ribaudo
    vedantroy and nicolo-ribaudo committed Feb 1, 2020
    Copy the full SHA
    be442d9 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2020

  1. Idiomatically generate UidIdentifier

    @vedantroy
    vedantroy committed Feb 4, 2020
    Copy the full SHA
    53fad8e View commit details
    Browse the repository at this point in the history

  2. Update scope after replacing loop declaration

    @vedantroy
    vedantroy committed Feb 4, 2020
    Copy the full SHA
    14b8c14 View commit details
    Browse the repository at this point in the history