Wrap type-only class fields in flow comments #11096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Internal 🏠
nicolo-ribaudo
commented
Feb 5, 2020
| @@ -1,7 +1,7 @@ | |||
| // @flow | |||
|
|
|||
| import type { Options } from "../options"; | |||
| import type { File, JSXOpeningElement } from "../types"; | |||
| import type { File /*::, JSXOpeningElement */ } from "../types"; | |||
There was a problem hiding this comment.
This is needed otherwise ESLint marks it as unused (because it's "used" inside a comment).
existentialism
approved these changes
Feb 8, 2020
rajasekarm
pushed a commit
to rajasekarm/babel
that referenced
this pull request
Feb 17, 2020
* Wrap type-only class fields in flow comments * Fix
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current code will break when #10039 is fixed. This has been caught by #10120.
I will push this commit to #10120 to check if this is enough, please don't merge this PR until we are sure that e2e tests pass.