New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Yarn 2 #11167
Use Yarn 2 #11167
Conversation
b56a778
to
c9bbfdd
Compare
.circleci/config.yml
Outdated
- &save-yarn-cache | ||
paths: | ||
- .yarn/cache | ||
key: v2-yarn-cache | ||
|
||
- &save-node-modules-cache | ||
# Cache big node_modules folders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(😢We are cursed by not using PnP)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, after yarnpkg/berry#955 we don't need to cache it anymore!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That PR is merged, guess we can get rid of the cache?
66070cd
to
5788ad5
Compare
New failure which wasn't there before the rebase 🙃 |
Interesting, I tried locally but can't repro it 🤔 Can you try pushing an empty commit to run the test again while preserving the logs for future reference? I wonder if it's consistent. Printing the n_m content might also help shed some light. |
5788ad5
to
de83a9f
Compare
@arcanis Currently, Travis CI automatically caches it for JavaScript projects: it might be good to reach out to them asking to automatically cache |
@nicolo-ribaudo Please note, that I'm sure that node-modules linker in berry's |
Yeah, I'm using that PR (not master). |
5d804f4
to
88a5ab4
Compare
@nicolo-ribaudo I'm hesitant about if it is right to reuse the cached |
88a5ab4
to
fdde7eb
Compare
So far I have disabled |
36fb287
to
e177dbd
Compare
The windows build is failing because of a permission problem. The Ctrl+F for |
It works 🎉 🎉 🎉 |
57dc6a9
to
3275c39
Compare
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/24241/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - for what it's worth, we also use the Babel repo as part of our E2E tests for the n-m linker, so that should help ensure that this setup will always work.
12e175d
to
921a828
Compare
|
NOTE: When rebasing, this commit can cause a lot of conflicts. You can run this script (choose the correct one) in the monorepo root to automatically fix them.
* Update husky * Update Makefile * Update CI config * Update e2e and utils bash scripts * Patch lerna * Directly spawn node. This won't work with PnP * Don't make lerna ignore codemods and eslint packages * Add yarn.lock * Use process.execPath * Updates the e2e upgrade * Updates build * Update e2e old babel * Fix e2e babel old * Simplify e2e old babel script * Update lockfile * Update preset-env fixtures * Remove nested lock files * Fix codesandbox
921a828
to
4392d8c
Compare
* Update husky * Update Makefile * Update CI config * Update e2e and utils bash scripts * Patch lerna * Directly spawn node. This won't work with PnP * Don't make lerna ignore codemods and eslint packages * Add yarn.lock * Use process.execPath * Updates the e2e upgrade * Updates build * Update e2e old babel * Fix e2e babel old * Simplify e2e old babel script * Update lockfile * Update preset-env fixtures * Remove nested lock files * Fix codesandbox
4392d8c
to
aacfc03
Compare
I'm counting @arcanis's review for our two-:white_check_mark: policy, since as a Yarn maintainer he is one of the most qualified people out there to review this PR! |
NOTE: When rebasing, this commit can cause a lot of conflicts. You can run this script (choose the correct one) in the monorepo root to automatically fix them.
NOTE: When rebasing, this commit can cause a lot of conflicts. You can run this script (choose the correct one) in the monorepo root to automatically fix them.
* Update husky * Update Makefile * Update CI config * Update e2e and utils bash scripts * Patch lerna * Directly spawn node. This won't work with PnP * Don't make lerna ignore codemods and eslint packages * Add yarn.lock * Use process.execPath * Updates the e2e upgrade * Updates build * Update e2e old babel * Fix e2e babel old * Simplify e2e old babel script * Update lockfile * Update preset-env fixtures * Remove nested lock files * Fix codesandbox
As of now, CONTRIBUTING.md on
Should the instructions be changed in a follow-up PR? The doc should probably include tips on how to use yarn2 without uninstalling yarn1 because this is what most devs are still using. |
Yarn will shell out to the local version in the repository so that isn't an issue. |
The documentation is still up to date - as of this PR the Yarn version is stored within the repository, external contributors only need a global Yarn, regardless of its version. |
NOTE: When rebasing, this commit can cause a lot of conflicts. You can run this script (choose the correct one) in the monorepo root to automatically fix them.
* Update husky * Update Makefile * Update CI config * Update e2e and utils bash scripts * Patch lerna * Directly spawn node. This won't work with PnP * Don't make lerna ignore codemods and eslint packages * Add yarn.lock * Use process.execPath * Updates the e2e upgrade * Updates build * Update e2e old babel * Fix e2e babel old * Simplify e2e old babel script * Update lockfile * Update preset-env fixtures * Remove nested lock files * Fix codesandbox
Prev: #11142
NOTE to whoever rebases this PR
To solve conflicts related to the
workspace:
protocol inpackage.json
s, use this script: