Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Statement" as alias to Flow enum declaration #11184

Merged
merged 1 commit into from Feb 28, 2020
Merged

Add "Statement" as alias to Flow enum declaration #11184

merged 1 commit into from Feb 28, 2020

Conversation

gkz
Copy link
Contributor

@gkz gkz commented Feb 27, 2020

In Babel types, if something is a declaration it should also be listed as a statement. (e.g. see the definition of function declarations, variable declarations, etc.) I missed doing this when defining the type.

Q                       A
Fixed Issues?
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@existentialism existentialism added area: flow PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Feb 27, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 9c261ae into babel:master Feb 28, 2020
@gkz gkz deleted the enum-declaration-aliases branch February 28, 2020 17:24
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants