New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log after subsequent compilations in --watch mode #11220
Conversation
: filenameOrDir, | ||
); | ||
|
||
compiledFiles++; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will compiledFiles
be incremented twice if a single file is modified twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the current implementation, if it is modified twice in a very short period of time, yes.
Do you think that the memory/complexity of using a Set
with the file paths instead of the simple counter? (This may look like a rhetorical question, but it's not 😅)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On devtools like Babel I prefer correctness over performance unless it becomes our bottleneck.
On the other hand, thinking of the DX, does Successfully compiled # files with babel
really deliver value? I mean as a developer I would not care how many files are compiled, especially when in watch mode. In Babel repo we are printing the compiled path, execution timestamp in watch mode. If one is changing a single file using babel-cli, it will keep printing successfully compiled 1 file with Babel
so babel-cli can not assure users that the file has been compiled after they saved it.
What about printing things like "successfully compiled after 346ms", not ideal but at least they are more likely to differ across different runs.
I am okay to leave it as-is and address this in a separate DX PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm up for adjusting the message too, in a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It now logs
Successfully compiled 3 files with Babel (123ms).
d2b521f
to
31be452
Compare
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/22343/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a7ffc87:
|
Co-authored-by: James Munson <jmunson@gmail.com>
This is a revision of #6320.
--noisy
option. We already have--quiet
and--verbose
, and a third option would be too much (unless we implement something like--loglevel
). I made it the default behavior since it just replicates what@babel/cli
already does.lodash/debounce
instead of a custom implementation.