fix: do not remove shadowed for-loop declarators #11242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Bug Fix 🐛
| state.iife = true; | ||
| // for (var x in {}); should not be removed | ||
| const declaration = redeclarator.parentPath; | ||
| if (!declaration.parentPath.isFor({ left: declaration.node })) { |
There was a problem hiding this comment.
In for (...;...;...) statements left doesn't exist: it's called init.
If you meant to only check for-of and for-in (but I don't think so), then you need ForXStatement.
💡 Idea: an ESLint plugin that prevents us from checking non-existent properties (like in this case).
nicolo-ribaudo
approved these changes
Mar 12, 2020
existentialism
approved these changes
Mar 12, 2020
|
Release is coming! |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitelist var declarator in for loop when we are removing shadowed uninitialized variable declarators.
This PR is a follow-up to #11158 .