Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw better errors for non-iterables when Symbol doesn't exist. #11264

Merged
merged 1 commit into from Mar 16, 2020
Merged

Throw better errors for non-iterables when Symbol doesn't exist. #11264

merged 1 commit into from Mar 16, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Mar 14, 2020 •
edited

Q                       A
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR also checks if Symbol is defined before using it so that it won't throw Cannot get property "iterator" of undefined anymore but "Object is not an iterable"

Part 1b/n

@nicolo-ribaudo nicolo-ribaudo added the PR: Polish 💅 A type of pull request used for our changelog categories label Mar 14, 2020
@nicolo-ribaudo nicolo-ribaudo added this to Ready for review in Iterables DX Mar 14, 2020
@nicolo-ribaudo nicolo-ribaudo force-pushed the iterables-dx/rest-spread-better-error-messages branch from 385cf05 to a3f5bbb Compare March 15, 2020 14:10
@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review March 15, 2020 15:37
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Mar 15, 2020
Merged
existentialism
existentialism approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolo-ribaudo nicolo-ribaudo merged commit 1ba41f2 into master Mar 16, 2020
Iterables DX automation moved this from Ready for review to Done Mar 16, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the iterables-dx/rest-spread-better-error-messages branch March 17, 2020 01:00
This was referenced Mar 22, 2020
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 30, 2020
Open
Open
Open
Open
This was referenced Apr 11, 2020
Merged
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 17, 2020
Open
Open
Open
Open
Open
This was referenced Apr 24, 2020
Open
Open
Open
Closed
Open
Open
Merged
This was referenced May 2, 2020
Open
Merged
Open
Closed
Open
Open
Open
Open
@vcarl vcarl mentioned this pull request Jun 15, 2020
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
No open projects
Iterables DX
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolo-ribaudo @existentialism @jridgewell