Allow for-of on polyfilled or builtin iterables without Symbol support
#11285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Bug Fix 🐛
JLHwung
reviewed
Mar 19, 2020
|
|
||
| function _unsupportedIterableToArray(o, minLen) { if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = Object.prototype.toString.call(o).slice(8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return Array.from(n); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); } | ||
|
|
||
| function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; } |
There was a problem hiding this comment.
unrelated to this PR: I am thinking if it is worthy to add external-helpers in fixture-runners, so when we update the codes of helpers, we don't have to update fixtures.
There was a problem hiding this comment.
Definitely yes. Maybe we should somehow enable external-helpers by default in out input/output tests.
JLHwung
approved these changes
Mar 19, 2020
jridgewell
approved these changes
Mar 19, 2020
This was referenced Mar 22, 2020
This was referenced Mar 30, 2020
This was referenced Apr 11, 2020
This was referenced Apr 18, 2020
This was referenced Apr 26, 2020
This was referenced May 4, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically what comes out by "merging" #11268 and #11263 together.