Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct this in __self for JSX elements in arrows #11288

Merged
merged 6 commits into from Mar 19, 2020
Merged

Use the correct this in __self for JSX elements in arrows #11288

merged 6 commits into from Mar 19, 2020

Commits on Mar 19, 2020

  1. Inject __source and __self in JSX elements earlier 

    This fixes an issue where `this` was not correct inside arrow functions, similar to
https://astexplorer.net/#/gist/86638d64cd21c496e7fecaea46313d95/906f8be24d7d99f3f5cd5a956a48355e1864f4b1
    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 19, 2020
    Copy the full SHA
    b53d658 View commit details
    Browse the repository at this point in the history

  2. Add test

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 19, 2020
    Copy the full SHA
    fceb487 View commit details
    Browse the repository at this point in the history

  3. Remove try-catch

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 19, 2020
    Copy the full SHA
    5ae1db6 View commit details
    Browse the repository at this point in the history

  4. Update error

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 19, 2020
    Copy the full SHA
    121d025 View commit details
    Browse the repository at this point in the history

  5. Update fixtures

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 19, 2020
    Copy the full SHA
    61c1e5b View commit details
    Browse the repository at this point in the history

  6. Update windows fixtures

    @nicolo-ribaudo
    nicolo-ribaudo committed Mar 19, 2020
    Copy the full SHA
    74bd22d View commit details
    Browse the repository at this point in the history