[preset-typescript] Fix private members type annotations #11315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore the CI failure, it is caused by an outdated base branch. |
nicolo-ribaudo
added
area: typescript
PR: Bug Fix 🐛
| @@ -325,13 +330,16 @@ export default declare( | |||
| // class transform would transform the class, causing more specific | |||
| // visitors to not run. | |||
| path.get("body.body").forEach(child => { | |||
| if (child.isClassMethod()) { | |||
| if (child.isClassMethod() || child.isClassPrivateMethod()) { | |||
There was a problem hiding this comment.
Note: this doesn't actually fix anything, but I'm ok with keeping it since we could add new things to the method handler, which could be also allowed with private methods.
There was a problem hiding this comment.
Yes, I left it for consistency and for possible further changes
jridgewell
approved these changes
Mar 23, 2020
existentialism
approved these changes
Mar 23, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug when typescript transformer leaves type annotations for private properties. It does two main things: