Test Babel compiled using an old version of @babel/core
#11319
Conversation
This should catch regressions where we use a new helper without a fallback for older versions, or when we use a new @babel/traverse method.
| #==============================================================================# | ||
|
|
||
| startLocalRegistry "$PWD"/scripts/integration-tests/verdaccio-config.yml | ||
| yarn upgrade --scope @babel |
There was a problem hiding this comment.
Is yarn upgrade working again in our repo?
There was a problem hiding this comment.
Oh ignore me, it doesn't work. According to the docs, yarn upgrade doesn't modify package.json if it's not needed, but it still updates the dependencies. You can see that yarn.lock changes after running this command.
There was a problem hiding this comment.
We have replaced yarn upgrade by an ad-hoc script in #11021 due to yarnpkg/yarn#7797. I am not sure if that issue has been fixed or it affects only yarn upgrade-interactive so yarn upgrade is good.
There was a problem hiding this comment.
It doesn't give problems here because we are not using yarn workspaces.
In yarn 2 it's probably fixed since it is a complete rewrite, but if it's not I can work around it in whichever of those two PRs (this one or yarn 2) gets merged last.
|
Thanks for all the reviews and thanks to me for the PR! I didn't enable the test 🤣 |
nicolo-ribaudo
force-pushed
the
e2e-old-babel
branch
from
171b563
to
6f855dc
Compare
|
Tests can't fail if they don't run! |
github-actions
bot
added
the
outdated
This should catch regressions where we use a new helper without a fallback
for older versions, or when we use a new
@babel/traversemethod.