Compact parser fixture loc info #11322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
JLHwung
force-pushed
the
compact-parser-fixture-loc-info
branch
from
bd783c4
to
78af985
Compare
kaicataldo
approved these changes
Mar 23, 2020
JLHwung
force-pushed
the
compact-parser-fixture-loc-info
branch
from
78af985
to
a93d80b
Compare
|
@nicolo-ribaudo CI is green now. 😄 |
nicolo-ribaudo
approved these changes
Mar 23, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another MX (Maintinaer Experience) PR.
When working on babel parser, the fixture is typically too long to skim. One of obstacles are the
locinfo occupies many lines. This PR compacts the fixtures a bit so now it should be easier to read the test fixtures.For example, see if you can read this fixture now: https://github.com/babel/babel/blob/bd783c4543d74ffa8f2a248ea449eda64d4fdf77/packages/babel-parser/test/fixtures/comments/basic/array-pattern-trailing-comma/output.json
Please review the first commit only as the whole diff turns out too large for GitHub.
The idea is stolen from the Flow repo.