fix: check parentheses between optional chain and other types #11325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
jridgewell
approved these changes
Mar 24, 2020
| @@ -59,8 +59,12 @@ export function UpdateExpression(node: Object, parent: Object): boolean { | |||
| return ( | |||
| // (foo++).test(), (foo++)[0] | |||
| t.isMemberExpression(parent, { object: node }) || | |||
| // (foo++)?.test(), (foo++)?.[0] | |||
| t.isOptionalMemberExpression(parent, { object: node }) || | |||
There was a problem hiding this comment.
Perhaps we should be adding an alias for these, so we don't need to duplicate everywhere.
There was a problem hiding this comment.
It's really difficult to come up with a proper name other than CallExpression/MemberExpression itself. 😄
There was a problem hiding this comment.
Yah, I was thinking isMemberish and isCallish.
nicolo-ribaudo
approved these changes
Mar 24, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule of thumb: copy
isCallExpressionandisMemberExpressionreferences whenever thebaseitself is not an optional chain.