Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e publish test when branching from an older version #11347

Merged
merged 4 commits into from Mar 30, 2020

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? All the e2e tests which start failing after a new version
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The current e2e tests publish a new patch version starting from the PR branch. However, when the PR has an older version than the last published one, the tests fail with Cannot publish ...@undefined over existing version (example).

I have created this PR forking from 7.9.0, let's see if it works.

@nicolo-ribaudo nicolo-ribaudo added area: tests PR: Internal 🏠 A type of pull request used for our changelog categories labels Mar 28, 2020
@nicolo-ribaudo
Copy link
Member Author

Ok it fails lol

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy bash-node interaction.

@nicolo-ribaudo
Copy link
Member Author

It's because I'm bad at bash but good at JS 😂

@JLHwung JLHwung merged commit 548cb3e into babel:master Mar 30, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the e2e-publish-overwritten-version branch March 30, 2020 19:53
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants