Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Incorrect destructuring compilation of `for (let [[x] = [1]] = []… #11360

Merged
merged 1 commit into from Apr 7, 2020
Merged

fix Incorrect destructuring compilation of `for (let [[x] = [1]] = []… #11360

merged 1 commit into from Apr 7, 2020

Conversation

Zzzen
Copy link
Contributor

@Zzzen Zzzen commented Apr 1, 2020

…;;) (#9963)

Q                       A
Fixed Issues? Fixes #9963
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link No
Any Dependency Changes? No
License MIT

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Apr 5, 2020
nicolo-ribaudo
nicolo-ribaudo approved these changes Apr 5, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@existentialism existentialism merged commit ca096c5 into babel:master Apr 7, 2020
@existentialism
Copy link
Member

@Zzzen thanks!

@brianppoole
Copy link

Yesssss! Thank you!

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 8, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect destructuring compilation of for (let [[x] = [1]] = [];;) {...}
6 participants
@Zzzen @existentialism @brianppoole @JLHwung @nicolo-ribaudo @kaicataldo