Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transform-spread: create TS types (not Flow) when using TS #11378
transform-spread: create TS types (not Flow) when using TS #11378
Changes from 6 commits
87f459d
e0f3fc2
4740c97
ae08396
d9c792d
aa8c16a
fb48f70
7e2c323
65331a3
93d5af2
5e9c920
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically a breaking change: it makes the next
@babel/traverse
version incompatible with@babel/types
<= 7.9.5, because it doesn't contain this function.We should use
t.createTSUnionType?.(types)
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is true, thanks for mentioning that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolo-ribaudo it will change the behaviour as returns
UnionTypeAnnotation
and now it returnsundefined
I added if-check in 5e9c920
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix 💊
Changes are also applied for
LogicalExpression
- https://github.com/babel/babel/pull/11378/files#diff-6c956a118dc9996dff6b731e42856479R85getTypeAnnotationBindingConstantViolations
- https://github.com/babel/babel/pull/11378/files#diff-1fce3c9f392392fe193c399ad4a97b65R99getConditionalAnnotation
- https://github.com/babel/babel/pull/11378/files#diff-1fce3c9f392392fe193c399ad4a97b65R212There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using typescript implementation here: https://github.com/babel/babel/pull/11378/files#diff-31b76153974cd0302007f05a570dfde6R10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First I tried
TSTypeParameter
e0f3fc2#diff-31b76153974cd0302007f05a570dfde6R49Now I'm sure it does NOT cover all cases