Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish: recommend preset for js extensions #11421

Merged
merged 1 commit into from Apr 16, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 14, 2020

Q                       A
Fixed Issues? Per #11417 (review)
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR recommends @babel/preset- whenver available. Besides that, it also mentions the syntax plugin. People may intend to leave it untranspiled, i.e. in a babel/syntax-typescript + tsc workflow.

@JLHwung JLHwung added PR: Polish 💅 A type of pull request used for our changelog categories area: errors pkg: core labels Apr 14, 2020
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks 😄

@JLHwung JLHwung force-pushed the polish-missing-plugin-helpers branch from 3e6af4b to 7874fa2 Compare April 15, 2020 20:02
@nicolo-ribaudo
Copy link
Member

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 1c09701 into babel:master Apr 16, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the polish-missing-plugin-helpers branch April 16, 2020 19:14
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 17, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: errors outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: core PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants