Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable e2e-babel-old-version test #11477

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
License MIT

Since Babel 8 is expected to break compatibility with Babel 7.0.0, it doesn't make sense to test it.

For example, it (correctly) fails in #11468

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21279/

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we need to re-enable it after the first Babel 8 release is published so it becomes e2e-babel-old-8.

@nicolo-ribaudo
Copy link
Member Author

That's why I commented the code instead of deleting it!

@nicolo-ribaudo nicolo-ribaudo merged commit d85d4f9 into babel:next-8-dev Apr 24, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the disable-e2e-babel-old-version-test branch April 24, 2020 22:09
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants