Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getters and setters support in generator for declare class statement #11502

Merged
merged 1 commit into from Apr 30, 2020
Merged

getters and setters support in generator for declare class statement #11502

merged 1 commit into from Apr 30, 2020

Conversation

zxbodya
Copy link
Contributor

@zxbodya zxbodya commented Apr 29, 2020

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

Change is adding support for getters and setters in babel-generator for flow DeclareClass statement.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21667/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 184869d:

Sandbox Source
affectionate-goldwasser-k04fu Configuration
objective-bose-5cc26 Configuration

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator labels Apr 30, 2020
JLHwung
JLHwung approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@nicolo-ribaudo
Copy link
Member

CI failure is unrelated

@nicolo-ribaudo nicolo-ribaudo merged commit 96ccf56 into babel:master Apr 30, 2020
@zxbodya zxbodya deleted the bugfix-declare-class-get-set branch April 30, 2020 08:18
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 31, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zxbodya @babel-bot @nicolo-ribaudo @existentialism @JLHwung