New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide internal @babel/core
functions in config errors
#11554
Merged
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b61826d
Hide internal `@babel/core` functions in config errors
nicolo-ribaudo 74cd5f5
Fixes
nicolo-ribaudo 67af9a5
All entry points
nicolo-ribaudo 53b7938
Add a test for internal errors
nicolo-ribaudo fefa347
Remove line numbers in snapshot
nicolo-ribaudo 655a4d9
Hide more jest frames
nicolo-ribaudo b08d515
Fix Node.js 10 tests
nicolo-ribaudo fae9608
Fix Node.js 8 and 6 tests
nicolo-ribaudo a75ea8b
Fix windows tests
nicolo-ribaudo 8bdadb3
fix windows test
liuxingbaoyu ce9f2d2
Update packages/babel-core/test/errors-stacks.js
nicolo-ribaudo 89542ad
Move type casts to config validation
nicolo-ribaudo 358f2c5
Review
nicolo-ribaudo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there is some lint rule to make it a normal string, but in this PR I think it's ok.🤫
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's @typescript-eslint/quotes, which can be configured with
allowTemplateLiterals: false
to avoid unnecessary template literals (despite the name, it does not forbid all usage of template literals). To be compatible with Prettier,avoidEscape: true
must also be set (even if you extendeslint-config-prettier
, individual rule configurations take precedence).