Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use repository.directory field in package.json files #11625

Conversation

saulosantiago
Copy link
Contributor

@saulosantiago saulosantiago commented May 27, 2020

Q                       A
Fixed Issues? Fixes #11619
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Changed all packages.json's files, adding the new repository field for sub-packages.

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7454f22:

Sandbox Source
floral-brook-g5cfc Configuration
confident-sea-gwdkl Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented May 27, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/22956/

@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label May 27, 2020
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than @nicolo-ribaudo's comment

saulosantiago and others added 2 commits May 27, 2020 11:09
….json

Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
@nicolo-ribaudo
Copy link
Member

Thanks!

@nicolo-ribaudo nicolo-ribaudo changed the title Modifying all our package.json's to use a different value for the repository field Use repository.directory field in package.json files May 27, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 242d9e0 into babel:master May 27, 2020
@saulosantiago
Copy link
Contributor Author

Thanks for give me this opportunity to contribute :)

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify all our package.json's to use a different value for the repository field
5 participants