New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build config to work the same when running on windows #11688
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25197/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 35c566f:
|
@@ -115,14 +122,14 @@ module.exports = function(api) { | |||
test: [ | |||
"packages/babel-parser", | |||
"packages/babel-helper-validator-identifier", | |||
], | |||
].map(normalize), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Babel 8 I'd like to normalize the paths internally in @babel/core
I admit that I have no idea 🤔 |
It seems that you didn't change it to |
Good catch, indeed changing it to |
It looks - Also, apparently if not providing custom @nicolo-ribaudo what you think? should I revert changes |
Currently our Travis Windows CI will skip standalone build, @zxbodya Can you rebase? |
f885813
to
35c566f
Compare
@JLHwung rebased it. |
While debugging failing windows build for #11578 (https://travis-ci.com/github/babel/babel/jobs/345463718) found a problem bundling
babel-standalone
: it was failing when trying to bundle./lib/config/files/index.js
instead of./src/config/files/index-browser.ts
frombabel-core
Fixes for it are in two places:
scripts/rollup-plugin-babel-source.js
-load
there was not handling windows path separator correctlybabel.config.js
- filter fix in rollup config, some modules failed to compile because babel config overrides were not applied on windows for the same path separator issue.However, I still do not understand - how current master version can build correctly on windows… It looks like there is some other place in rollup to use
browser
field, but then - why it would change after converting sources to typescript