Update transform-unicode-escapes test to output minimal strings #11721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Bug Fix 🐛
nicolo-ribaudo
commented
Jun 15, 2020
| manipulateOptions(opts) { | ||
| opts.generatorOpts.jsescOption = { | ||
| minimal: false, | ||
| ...opts.generatorOpts.jsescOption, |
There was a problem hiding this comment.
Should I swap these lines? Or throw an error if jsescOption is set to true?
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cd52a04:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/24119/ |
jridgewell
requested changes
Jun 16, 2020
There was a problem hiding this comment.
I actually think this is fine to leave as is. Given:
// Input
const \u{1d49c} = "\u{1d49c}";
// minimal: false (this PR)
var _ud835_udc9c = "\uD835\uDC9C";
// minimal: true (current next-8)
var _ud835_udc9c = "𝒜";The non-ASCII 𝒜 inside strings is actually fine, and well-supported back to ES5 browsers. That's actually a valid transform we could have done with #11377.
nicolo-ribaudo
force-pushed
the
minimal-strings-transform-escapes-compatibility
branch
from
10bad01
to
cd52a04
Compare
nicolo-ribaudo
changed the title
nicolo-ribaudo
deleted the
minimal-strings-transform-escapes-compatibility
branch
nicolo-ribaudo
added
area: tests
and removed
PR: Bug Fix 🐛
nicolo-ribaudo
added a commit
that referenced
this pull request
Jun 18, 2020
nicolo-ribaudo
added a commit
that referenced
this pull request
Jun 20, 2020
nicolo-ribaudo
added a commit
that referenced
this pull request
Jul 5, 2020
nicolo-ribaudo
added a commit
that referenced
this pull request
Aug 28, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next-8-devis currently failing; this PR fixes it.While merging
masterintonext-8-dev, I noticed that #11384 and #11377 are incompatible with eachother.This PR attemps to fix it by setting
jsescOption.minimal: falsewhen usingtransform-unicode-escapes.