Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better parser error when using jsx #11722

Merged
merged 6 commits into from Jun 22, 2020
Merged

Add better parser error when using jsx #11722

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a74a52f
Add "<" parser tests
penguingovernor Jun 16, 2020
36c699e
Add: better parser error when using jsx
penguingovernor Jun 16, 2020
22fda5a
Add: babel parser test
penguingovernor Jun 17, 2020
d81329f
Add: no flow but with typescript test
penguingovernor Jun 18, 2020
31c9f07
Add: type paramter test with no plugins (no flow)
penguingovernor Jun 18, 2020
4357684
Add: unclosed jsx element test
penguingovernor Jun 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/babel-parser/src/parser/expression.js
View file
Open in desktop
Expand Up @@ -1170,6 +1170,12 @@ export default class ExpressionParser extends LValParser {
}
}
// fall through
case tt.relational: {
if (this.state.value === "<") {
throw this.expectOnePlugin(["jsx", "flow", "typescript"]);
}
}
// fall through
default:
throw this.unexpected();
}
Expand Down
1 change: 1 addition & 0 deletions packages/babel-parser/test/fixtures/jsx/errors/_no-plugin-jsx-expression/input.js
View file
Open in desktop
@@ -0,0 +1 @@
<div>{name}</div>
4 changes: 4 additions & 0 deletions packages/babel-parser/test/fixtures/jsx/errors/_no-plugin-jsx-expression/options.json
View file
Open in desktop
@@ -0,0 +1,4 @@
{
"plugins": [],
"throws": "This experimental syntax requires enabling one of the following parser plugin(s): 'jsx, flow, typescript' (1:0)"
}
2 changes: 2 additions & 0 deletions packages/babel-parser/test/fixtures/jsx/errors/_no-plugin-no-jsx/input.js
View file
Open in desktop
@@ -0,0 +1,2 @@
"use strict"
<div
36 changes: 36 additions & 0 deletions packages/babel-parser/test/fixtures/jsx/errors/_no-plugin-no-jsx/output.json
View file
Open in desktop
@@ -0,0 +1,36 @@
{
"type": "File",
"start":0,"end":17,"loc":{"start":{"line":1,"column":0},"end":{"line":2,"column":4}},
"program": {
"type": "Program",
"start":0,"end":17,"loc":{"start":{"line":1,"column":0},"end":{"line":2,"column":4}},
"sourceType": "script",
"interpreter": null,
"body": [
{
"type": "ExpressionStatement",
"start":0,"end":17,"loc":{"start":{"line":1,"column":0},"end":{"line":2,"column":4}},
"expression": {
"type": "BinaryExpression",
"start":0,"end":17,"loc":{"start":{"line":1,"column":0},"end":{"line":2,"column":4}},
"left": {
"type": "StringLiteral",
"start":0,"end":12,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":12}},
"extra": {
"rawValue": "use strict",
"raw": "\"use strict\""
},
"value": "use strict"
},
"operator": "<",
"right": {
"type": "Identifier",
"start":14,"end":17,"loc":{"start":{"line":2,"column":1},"end":{"line":2,"column":4},"identifierName":"div"},
"name": "div"
}
}
}
],
"directives": []
}
}
1 change: 1 addition & 0 deletions packages/babel-parser/test/fixtures/jsx/errors/_no-plugin-ts-type-param/input.js
View file
Open in desktop
@@ -0,0 +1 @@
<div>() => {}
penguingovernor marked this conversation as resolved.
Show resolved Hide resolved
43 changes: 43 additions & 0 deletions packages/babel-parser/test/fixtures/jsx/errors/_no-plugin-ts-type-param/output.json
View file
Open in desktop
@@ -0,0 +1,43 @@
{
"type": "File",
"start":0,"end":13,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":13}},
"program": {
"type": "Program",
"start":0,"end":13,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":13}},
"sourceType": "script",
"interpreter": null,
"body": [
{
"type": "ExpressionStatement",
"start":0,"end":13,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":13}},
"expression": {
"type": "ArrowFunctionExpression",
"start":0,"end":13,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":13}},
"id": null,
"generator": false,
"async": false,
"params": [],
"body": {
"type": "BlockStatement",
"start":11,"end":13,"loc":{"start":{"line":1,"column":11},"end":{"line":1,"column":13}},
"body": [],
"directives": []
},
"typeParameters": {
"type": "TypeParameterDeclaration",
"start":0,"end":5,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":5}},
"params": [
{
"type": "TypeParameter",
"start":1,"end":4,"loc":{"start":{"line":1,"column":1},"end":{"line":1,"column":4}},
"name": "div",
"variance": null
}
]
}
}
}
],
"directives": []
}
}
1 change: 1 addition & 0 deletions packages/babel-parser/test/fixtures/jsx/errors/_no_plugin/input.js
View file
Open in desktop
@@ -0,0 +1 @@
<div></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the following test case?

<div>{name}</div>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and done (:

4 changes: 4 additions & 0 deletions packages/babel-parser/test/fixtures/jsx/errors/_no_plugin/options.json
View file
Open in desktop
@@ -0,0 +1,4 @@
{
"throws": "This experimental syntax requires enabling one of the following parser plugin(s): 'jsx, flow, typescript' (1:0)",
"plugins": []
}