New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(do-expr): SwitchStatement with IfStatement cases #11728
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7ce7758
test(do-expr): condition before break
ed71ebf
test(do-expr): labeled break
8439fc8
fix(do-expr): add check for break in BlockStatement
363e2a5
fix(do-expr): add LabeledStatement case for getCompletionRecords
063baf0
test(do-expr): rename condition before break to condition before expr…
38088a1
revert(do-expr): undo remove break for do switch
1cbb509
revert(do-expr): undo remove labeled break
8cadeb1
test(do-expr): add condition before break
3723a28
test(do-expr): update condition before break
9510c99
test(do-expr): remove labeled break
a3c491a
fix(do-expr): add tree search in findBreak
cd1fdbb
fix(do-expr): ignore isFunction case in findBreak
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
...sal-do-expressions/test/fixtures/do-expression-switch-case/condition-before-break/exec.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
const x = (n) => do { | ||
switch (n) { | ||
case 0: | ||
if (true) { | ||
break; | ||
} | ||
} | ||
} | ||
|
||
expect(x(0)).toBe(undefined); |
8 changes: 8 additions & 0 deletions
8
...al-do-expressions/test/fixtures/do-expression-switch-case/condition-before-break/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
const x = (n) => do { | ||
switch (n) { | ||
case 0: | ||
if (true) { | ||
break; | ||
} | ||
} | ||
} |
6 changes: 6 additions & 0 deletions
6
...l-do-expressions/test/fixtures/do-expression-switch-case/condition-before-break/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
const x = n => function () { | ||
switch (n) { | ||
case 0: | ||
if (true) return void 0; | ||
} | ||
}(); |
10 changes: 10 additions & 0 deletions
10
...-expressions/test/fixtures/do-expression-switch-case/condition-before-expression/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
const x = (n) => do { | ||
switch (n) { | ||
case 0: | ||
if (true) { | ||
'out'; | ||
break; | ||
} | ||
|
||
} | ||
} |
9 changes: 9 additions & 0 deletions
9
...expressions/test/fixtures/do-expression-switch-case/condition-before-expression/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
const x = n => function () { | ||
switch (n) { | ||
case 0: | ||
if (true) { | ||
return 'out'; | ||
} | ||
|
||
} | ||
}(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test case where
BreakStatement
does not follow anExpressionStatement
?