Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript 4.0 support #11760

Merged
merged 4 commits into from Jul 29, 2020
Merged

TypeScript 4.0 support #11760

merged 4 commits into from Jul 29, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jun 29, 2020

⚠️ Use "Rebase and merge", not "Squash and merge"

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 29, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26005/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0b8ac7d:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung added PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release and removed PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release labels Jul 14, 2020
@JLHwung
Copy link
Contributor

JLHwung commented Jul 14, 2020

@nicolo-ribaudo Can you rebase?

nicolo-ribaudo and others added 4 commits July 15, 2020 22:51
* refactor: align with AST shape convention

* feat: print catch param type annotations

* test: add test case on transform
* TypeScript 4.0: Support labeled tuple elements

* More tests

* Disallow mixing labeled and unlabeled elements

* Update AST shape

* Enable test after rebase

* Allow labeled spread types

* Fix flow

* Add types and generator suport

* Update packages/babel-parser/src/plugins/typescript/index.js

* Prettier
@nicolo-ribaudo
Copy link
Member Author

Note that all these commits already have two approvals

@JLHwung JLHwung added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Jul 15, 2020
@JLHwung JLHwung merged commit eba4c3b into main Jul 29, 2020
@JLHwung JLHwung deleted the feat-7.11.0/ts-4.0 branch July 29, 2020 20:51
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release umbrella ☂️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants