Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lodash 'sortBy' usage with Array.prototype.sort #11810

Closed
wants to merge 33 commits into from
Closed

Replace lodash 'sortBy' usage with Array.prototype.sort #11810

wants to merge 33 commits into from

Commits on Jul 9, 2020

  1. Replace lodash 'sortBy' usage with Array.prototype.sort

    @jayaddison
    jayaddison committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    e003efe View commit details
    Browse the repository at this point in the history

  2. Rectify comment

    @jayaddison
    jayaddison committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    13fce2a View commit details
    Browse the repository at this point in the history

  3. Extract priority as local function

    @jayaddison
    jayaddison committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    5a38c24 View commit details
    Browse the repository at this point in the history

  4. Update packages/babel-core/src/transformation/block-hoist-plugin.js 

    Co-authored-by: Corey Farrell <git@cfware.com>
    @jayaddison @coreyfarrell
    jayaddison and coreyfarrell committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    67a41ad View commit details
    Browse the repository at this point in the history

  5. Flip Array.prototype.sort comparator argument order

    @jayaddison
    jayaddison committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    47cffbe View commit details
    Browse the repository at this point in the history

  6. Switch from Array.prototype.every to Array.prototype.find

    @jayaddison
    jayaddison committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    65099df View commit details
    Browse the repository at this point in the history

  7. Ensure stable element sort order for Node < 12 by retaining a map of … 

    …original element indices
    @jayaddison
    jayaddison committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    5ce6cf8 View commit details
    Browse the repository at this point in the history

  8. Fixup: null rather than false argument to Map constructor when sortin… 

    …g is stable
    @jayaddison
    jayaddison committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    3031dbf View commit details
    Browse the repository at this point in the history

  9. Update packages/babel-core/src/transformation/block-hoist-plugin.js 

    Co-authored-by: Corey Farrell <git@cfware.com>
    @jayaddison @coreyfarrell
    jayaddison and coreyfarrell committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    e84d4bb View commit details
    Browse the repository at this point in the history

  10. Nit: rephrase boolean fallback behaviour to ensure that sortIsUnstabl… 

    …e is strictly true/false
    @jayaddison
    jayaddison committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    a7e7a71 View commit details
    Browse the repository at this point in the history

  11. Nit: remove empty newline

    @jayaddison
    jayaddison committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8617a7f View commit details
    Browse the repository at this point in the history

  12. Refactor stabilityMap construction and comparator logic

    @jayaddison
    jayaddison committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8a2e5a8 View commit details
    Browse the repository at this point in the history

  13. Ensure that the sort comparator always returns a value

    @jayaddison
    jayaddison committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    a472de9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Pre-check whether NodeJS 'process' variable is defined

    @jayaddison
    jayaddison committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    fdd2756 View commit details
    Browse the repository at this point in the history

  2. Fixup: linting

    @jayaddison
    jayaddison committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    9e2db88 View commit details
    Browse the repository at this point in the history

  3. Update logical condition: use map as a tie-breaker for non-NodeJS env… 

    …ironments

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @jayaddison @nicolo-ribaudo
    jayaddison and nicolo-ribaudo committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    3ee06b3 View commit details
    Browse the repository at this point in the history

  4. Simplification: use Array.prototype.some instead of Array.prototype.f… 

    …ind since no return value is required

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @jayaddison @nicolo-ribaudo
    jayaddison and nicolo-ribaudo committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    e50df93 View commit details
    Browse the repository at this point in the history

  5. Simplify expression: invoke Object.entries instead of using an equiva… 

    …lent map expression

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @jayaddison @nicolo-ribaudo
    jayaddison and nicolo-ribaudo committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    8cc9106 View commit details
    Browse the repository at this point in the history

  6. Revert "Simplify expression: invoke Object.entries instead of using a… 

    …n equivalent map expression"

This reverts commit 8cc9106.
    @jayaddison
    jayaddison committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    55b6994 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. Merge branch 'main' into dependencies/reduce-lodash-usage-sortby

    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    d213549 View commit details
    Browse the repository at this point in the history

  2. Add key, value types to Map constructor

    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    264d0f3 View commit details
    Browse the repository at this point in the history

  3. Use semver to perform version parsing and comparison

    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    f681c41 View commit details
    Browse the repository at this point in the history

  4. Fixup: misplaced trailing semi-colon

    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    fad44b7 View commit details
    Browse the repository at this point in the history

  5. Fixup: add missing semver import

    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    3fdb680 View commit details
    Browse the repository at this point in the history

  6. Read node version from 'process.versions.node'

    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    f5764fa View commit details
    Browse the repository at this point in the history

  7. Use static string version instead of attempting semver parsing (from … 

    …an invalid version string..)
    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    3ddc74a View commit details
    Browse the repository at this point in the history

  8. babel-core: update to semver@^7.3.2

    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    af82e70 View commit details
    Browse the repository at this point in the history

  9. Skip flow type-checking for stabilityMap arithmetic

    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    1d7e4f3 View commit details
    Browse the repository at this point in the history

  10. Add flow type declaration for semver.clean

    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    2465432 View commit details
    Browse the repository at this point in the history

  11. Revert "babel-core: update to semver@^7.3.2" 

    This reverts commit af82e70.
    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    bef7e93 View commit details
    Browse the repository at this point in the history

  12. Add value presence check for nodeVersion

    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    d468331 View commit details
    Browse the repository at this point in the history

  13. lint: apply fixes suggested by prettier

    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    26a35d1 View commit details
    Browse the repository at this point in the history

  14. lint: apply string quoting fix suggested by prettier

    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    4f5673b View commit details
    Browse the repository at this point in the history