New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint-parser: ES2020 features #11815
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25849/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1d0f3d3:
|
71d6422
to
6935f68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some fixtures tests for ChainExpression
in @babel/parser
?
I don’t think this needs to block this PR, but we should make sure we bump the ESLint peer dep version once optional chaining lands in ESLint core (hopefully the next release). I also have a PR open to upgrade to ESLint v7, so if we can land that it should be an easy bump :) |
ESLint optional chaining PR here. |
6935f68
to
8ac1984
Compare
eslint-visitor-keys
is bumped to^1.3.0
which includes theChainExpression
visitor keys.This PR adds estree parsing support on the following features:
export * ns
(credits to @existentialism)The nullish coalescing is out of the box since ESTree and Babel shares the AST shape. Thus I have enabled test.
The
@babel/parser
estree
plugin now supports parsing optional chaining andexport * ns
.