chore: use repository HEAD when pulling third party repos #11837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
JLHwung
commented
Jul 14, 2020
| @@ -88,7 +88,7 @@ jobs: | |||
| - run: | |||
| name: Setup Test Runner | |||
| command: | | |||
| git clone --recurse-submodules https://github.com/babel/babel-test262-runner | |||
| git clone --depth=1 --recurse-submodules https://github.com/babel/babel-test262-runner | |||
There was a problem hiding this comment.
Note that --depth=N implies --single-branch.
JLHwung
commented
Jul 14, 2020
| git clone --branch=gh-pages --single-branch --shallow-since=2020-04-01 https://github.com/kangax/compat-table.git build/compat-table | ||
| cd build/compat-table && git checkout -qf $COMPAT_TABLE_COMMIT | ||
| git clone --single-branch --shallow-since=2020-04-01 https://github.com/kangax/compat-table.git build/compat-table | ||
| cd build/compat-table && git checkout -q $COMPAT_TABLE_COMMIT |
There was a problem hiding this comment.
-f is to suppress warning when working tree is different than HEAD. This is highly unlikely since we have removed build/compat-table before cloning.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25935/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 683ab0d:
|
nicolo-ribaudo
approved these changes
Jul 14, 2020
existentialism
approved these changes
Jul 14, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test262is planning to renamemasterintomain. In this PR we removes the--branchoption when cloning third-party repos. By doing sogitwill always clone the repositoryHEAD, which is the default branch HEAD as of GitHub repos -- so we are agnostic about upstream default branch name.