Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lodash 'isRegExp' usage with NodeJS util isRegExp (or a fallback when unavailable) #11856

Closed
wants to merge 18 commits into from
Closed

Replace lodash 'isRegExp' usage with NodeJS util isRegExp (or a fallback when unavailable) #11856

wants to merge 18 commits into from

Commits on Jul 20, 2020

  1. Replace lodash 'isRegExp' usage with is-regexp library

    @jayaddison
    jayaddison committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    f8654f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Assess isRegExp via NodeJS utils library where available, with string… 

    … prototype comparison fallback
    @jayaddison
    jayaddison committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    62b8ae9 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Add linebreaks for ternary condition

    @jayaddison
    jayaddison committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    50f7914 View commit details
    Browse the repository at this point in the history

  2. Ensure arrow function is used unambiguously

    @jayaddison
    jayaddison committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    43b08e2 View commit details
    Browse the repository at this point in the history

  3. Use double-quotes instead of single-quotes

    @jayaddison
    jayaddison committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    4cfd90b View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Merge branch 'main' into dependencies/reduce-lodash-usage-isregexp

    @jayaddison
    jayaddison committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    d25f092 View commit details
    Browse the repository at this point in the history

  2. nodeUtilTypes check only needs to be performed once 

    Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
    @jayaddison @ExE-Boss
    jayaddison and ExE-Boss committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    51a7033 View commit details
    Browse the repository at this point in the history

  3. Rewrite nodeUtilTypes check without optional chaining operator

    @jayaddison
    jayaddison committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    15365ff View commit details
    Browse the repository at this point in the history

  4. Avoid SyntaxError ambiguity regarding arrow function parameter list

    @jayaddison
    jayaddison committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    486b705 View commit details
    Browse the repository at this point in the history

  5. Apply linter fixes

    @jayaddison
    jayaddison committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    2815784 View commit details
    Browse the repository at this point in the history

  6. Fixup: one remaining lint cleanup

    @jayaddison
    jayaddison committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    7e5bbb4 View commit details
    Browse the repository at this point in the history

  7. Cleanup: brevity

    @jayaddison
    jayaddison committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    926ddd1 View commit details
    Browse the repository at this point in the history

  8. Static analysis: Add FlowIgnore statement with explanatory comment

    @jayaddison
    jayaddison committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    cbd5c9e View commit details
    Browse the repository at this point in the history

  9. Add Babel 8 todo note

    @jayaddison
    jayaddison committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    c39876a View commit details
    Browse the repository at this point in the history

  10. Refactor: remove use of try...catch block

    @jayaddison
    jayaddison committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    ed0537d View commit details
    Browse the repository at this point in the history

  11. Clarify Babel 8 todo note

    @jayaddison
    jayaddison committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    982ca4d View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2020

  1. Merge branch 'main' into dependencies/reduce-lodash-usage-isregexp

    @jayaddison
    jayaddison committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    081c22b View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. Merge branch 'main' into dependencies/reduce-lodash-usage-isregexp

    @jayaddison
    jayaddison committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    c4c2850 View commit details
    Browse the repository at this point in the history