Correctly check reserved word for PropertyDefinition: IdentifierReference

[JLHwung]

Q	A
Fixed Issues?	Fixes #10411
Patch: Bug Fix?	Yes
Tests Added + Pass?	Yes
License	MIT

For object shorthand property, e.g. ({ arguments }) is allowed because

PropertyDefinition -> IdentifierReference -> Identifier -> IdentifierName but not ReservedWord

and arguments and eval is not ReservedWord

For destructuring patterns, e.g. ({ arguments = 1 }) = {} is allowed (in sloppy mode) because

PropertyDefinition -> CoverInitializedName -> IdentifierReference -> Identifier -> IdentifierName but not ReservedWord

If the fourth argument of this.checkReservedWord is true, it should be applied on BindingIdentifier, where eval and arguments are forbidden. Therefore the fix here is to align the spec and pass false instead.

This PR fixes a downstream issue: angular/angular-cli#17439

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bdce7c3:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26313/

[nicolo-ribaudo]

For destructuring patterns, e.g. ({ arguments = 1 }) = {} is allowed because

I don't think so: the destructuring pattern must match the "AssignmentPattern" production, and:

12.15.7.1 Static Semantics: Early Errors

AssignmentProperty : IdentifierReference Initializer[opt]

• It is a Syntax Error if AssignmentTargetType of IdentifierReference is not simple.

12.1.3 Static Semantics: AssignmentTargetType

IdentifierReference : Identifier

1. If this IdentifierReference is contained in strict mode code and StringValue of Identifier is "eval" or "arguments", return invalid.
2. Return simple.

[JLHwung]

If this IdentifierReference is contained in strict mode code and StringValue of Identifier is "eval" or "arguments", return invalid.

As for destructuring, we will check the BindingIdentifier ReservedWord in checkLVal later:

babel/packages/babel-parser/src/parser/lval.js

Lines 353 to 359 in 2bf38fb

	this.state.strict &&
	// "Global" reserved words have already been checked by parseIdentifier,
	// unless they have been found in the id or parameters of a strict-mode
	// function in a sloppy context.
	(strictModeChanged
	? isStrictBindReservedWord(expr.name, this.inModule)
	: isStrictBindOnlyReservedWord(expr.name))

Thus the following test case still throws.

"use strict";
const { arguments } = foo();

Since we can not differentiate between CoverInitializedName and AssignmentProperty until we see an = or =>, I think the change here is okay.