Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure […map.keys] can be correctly transformed in loose mode #11901

Merged
merged 1 commit into from Jul 31, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-block-scoping/src/index.js
Expand Up @@ -518,7 +518,7 @@ class BlockScoping {
// remap loop heads with colliding variables
if (this.loop) {
// nb: clone outsideRefs keys since the map is modified within the loop
for (const name of [...outsideRefs.keys()]) {
for (const name of Array.from(outsideRefs.keys())) {
const id = outsideRefs.get(name);

if (
Expand Down
7 changes: 7 additions & 0 deletions packages/babel-standalone/test/babel.js
Expand Up @@ -210,6 +210,13 @@
}),
).not.toThrow();
});
it("#11897 - [...map.keys()] in Babel source should be transformed correctly", () => {
expect(() =>
Babel.transform("for (let el of []) { s => el }", {
plugins: ["transform-block-scoping"],
}),
).not.toThrow();
});
});
},
);