Do not cache non-existent config files forever #11906
Merged
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 62d71a7:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26818/ |
JLHwung
added
PR: Bug Fix 🐛
JLHwung
approved these changes
Aug 4, 2020
existentialism
approved these changes
Aug 4, 2020
devongovett
added a commit
to devongovett/babel
that referenced
this pull request
Oct 18, 2020
Missed a spot in babel#11906. Currently if you don't have a JS config file and then add one to your project, it will not be picked up without restarting the process. Changing from caching forever to never caching when files don't exist fixes the issue.
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
babelCore.loadPartialConfigin Parcel and noticed that after creating a.babelrcin a directory where non previously existed, this config was not picked up without restarting the process. This was due to Babel caching the fact that the file did not exist indefinitely. This is not a safe assumption, as the user can create a config file without restarting the process. Always checking the mtime should do the trick.Happy to add a test if someone can point me to a good place to do it. 😄