New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor [In] production parameter tracking #11930
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3547b55:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27073/ |
8ecfb78
to
310c520
Compare
@@ -2049,7 +2057,12 @@ export default class ExpressionParser extends LValParser { | |||
trailingCommaPos: ?number, | |||
): N.ArrowFunctionExpression { | |||
this.scope.enter(SCOPE_FUNCTION | SCOPE_ARROW); | |||
this.prodParam.enter(functionFlags(isAsync, false)); | |||
let flags = functionFlags(isAsync, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to inherit [In]
when the arrow function body is {
-less (concise body).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean!
This PR is a follow-up to #10956. In this PR we remove the
noIn
passed down toparseMaybeAssign
and replace it withthis.prodParam.hasIn
, which is only set inparseMaybeAssignAllowIn
,parseMaybeAssignDisallowIn
andparseExpression
. This aligns to the fact that in the spec[+In]
and[~In]
exist only inAssignmentExpression
andExpression
.Blocks #11931.