Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test main next merge #11963

Closed

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Aug 14, 2020

There were a lot of conflicts in CI config files, so I want to be sure that they still work

JLHwung and others added 30 commits July 2, 2020 11:32
* test: add console warn spy on register tests

* address review comments
* chore: refine yarn cache config

* fix: Circle CI does not support template on paths

* chore: manually update yarn cache key

* remove debug command
…ger (babel#11790)

* Replace lodash 'includes' usage with Array.prototype.includes

* Replace lodash 'values' usage with Object.values

* Replace lodash 'uniq' usage with Array.from(new Set(...))

* Property safety: ensure that ignoreSuites/ignoreTasks are populated prior to access

* Property safety: ensure that blacklistTypes is populated prior to access

* Revert "Replace lodash 'values' usage with Object.values"

This reverts commit 9fd3679.

* Replace lodash 'repeat' usage with String.prototype.repeat

* Replace lodash 'isinteger' usage with Number.isInteger

* Remove explicit lodash dependency from babel-generator package

* Update packages/babel-helper-transform-fixture-test-runner/src/index.js

Co-authored-by: Brian Ng <bng412@gmail.com>

* Rely on optional chaining operator as sole boolean check

* Handle additional optional chaining operator simplification

* Update type signature

Co-authored-by: Brian Ng <bng412@gmail.com>
* ensure only builders starting with lowercase are used

* update generate builders to have function name starting flow lowercase

* fix bug in deprecated builders

* remove comment about not yet discussed change in next major version
* Fix break/continue when switch is nested inside loop

* merge retCheck
* Replace lodash 'values' usage with Object.keys => .map(obj[key])

* Block scoping: refactor letReferences, outsideLetReferences as objects of type Map

* Remove lodash dependency from babel-plugin-transform-block-scoping

* Fixup: Add missing Object.keys call

* Fixup: Update remaining property accessors

* Coerce Map.values() iterator results into an array via spread operator

* Fixup: Map.put -> Map.set

* Fixup: undo incorrect variable de-duplication

* Replace array-spread-plus-map combination with Array.from call

* Extract an extendMap function as an attempt to create an optimization boundary

* Experiment: cast objects to string (eliminates one Map/object difference per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map )

* Fixup: perform String cast on map keys, not values

* Revert "Fixup: perform String cast on map keys, not values"

This reverts commit abdd147.

* Revert "Experiment: cast objects to string (eliminates one Map/object difference per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map )"

This reverts commit a4035c8.

* Experiment: filter keys via Object.prototype.hasOwnProperty.call

* Revert "Experiment: filter keys via Object.prototype.hasOwnProperty.call"

This reverts commit 491c093.

* Migrate back from Map-based reference storage to Object-based storage; access performance appears much improved for Object property access

* Revert "Migrate back from Map-based reference storage to Object-based storage; access performance appears much improved for Object property access"

This reverts commit 2119acc.

* Iterate over a clone of outsideRefs keys

* Revert "Extract an extendMap function as an attempt to create an optimization boundary"

This reverts commit 85689f2.

* Fixup: migrate remaining Object property access to Map.get in tdz module
* refactor: reorganize babel types definitions structure

* chore: update generated artifacts
* chore: update CONTRIBUTING.md [skip ci]

* Update CONTRIBUTING.md [skip ci]

Co-authored-by: Brian Ng <bng412@gmail.com>

* Update CONTRIBUTING.md [skip ci]

Co-authored-by: Brian Ng <bng412@gmail.com>

* Apply suggestions from code review [skip ci]

Co-authored-by: Brian Ng <bng412@gmail.com>

Co-authored-by: Brian Ng <bng412@gmail.com>
* refactor: replace caniuse-db by mdn-browser-compat-data

* fix broken test
* fix: allow 09.1_1 and 09e1_1 in sloppy mode

* polish: avoid extra input source scanning

* chore: move comment [skip ci]
* chore: use modules: “auto”

* address review comments
Co-authored-by: coderaiser <coderaiser@cloudcmd.io>
* babel-traverse: prefer clearer, reduced-bias option naming

* Apply suggestions from code review

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
JLHwung and others added 10 commits August 10, 2020 16:57
* chore: enable flowcheck on CI

* fix: flow errors
* Run exec tests in fresh contexts

* Reevaluate modules in every context

* Cache module code when running tests

* Eliminate weakmap accesses as much as possible

* Remove old multiline usage

* Using bundled polyfill to significantly increase performance

The individual requires for each file were the part that was sooooo slow.

* Drop LRU cache size

* Fixes

* Fix test

Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
* fix: push new token context when braceHashL is seen

* Update packages/babel-parser/src/tokenizer/context.js
* replace lineBreak.test by hasPrecedingLingBreak

* refactor: simplify updateContext
* remove unused codes

* refactor: remove unused parseAccessModifier

* refactor: remove redundant async function checks

* refactor: remove redundant class check in checkExport

* add more parser test cases

* Update packages/babel-parser/src/parser/statement.js

Co-authored-by: Brian Ng <bng412@gmail.com>

* chore: add sourceType: unambiguous test

Co-authored-by: Brian Ng <bng412@gmail.com>
* chore: run node 6 and 8 test on GitHub actions

* fix: apply dynamicImportUrlToPath polyfill on publish

* Apply hacks unconditionally

* try fix highlight issues

* address review comments

* chore: add test-legacy build env

* Update .travis.yml [skip ci]

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
@nicolo-ribaudo nicolo-ribaudo changed the base branch from main to next-8-dev August 14, 2020 21:18
@babel-bot
Copy link
Collaborator

babel-bot commented Aug 14, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27391/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f4fc5a6:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo marked this pull request as draft August 14, 2020 21:25
@nicolo-ribaudo
Copy link
Member Author

@arcanis Yarn is failing in the e2e test, and we are seeing the same failure in #11962.

Lerna bumps @babel/core to 7.11.4, and it updates the various dependencies on that package to @babel/core@workspace:^7.11.4. Then, during prepack, Yarn throws Error: @babel/core@workspace:^7.11.4: No local workspace found for this range. I tried to SSH into the CI, and I correctly see that package as existing:

cat packages/babel-core/package.json 
{
  "name": "@babel/core",
  "version": "7.11.1",

Do you have any idea of what could be happening?

@nicolo-ribaudo
Copy link
Member Author

This also fails with yarn-2.0.0-rc.36, so the error has probably been introduced by something else.

@arcanis
Copy link
Contributor

arcanis commented Aug 14, 2020

This error is only supposed to happen when you're using a workspace: dependency that doesn't even point to a workspace. When you're logged in, does running yarn workspaces list shows @babel/core?

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Aug 14, 2020

Yes, but it doesn't specify the version:

 YN0000: .
➤ YN0000: codemods/babel-plugin-codemod-object-assign-to-object-spread
➤ YN0000: codemods/babel-plugin-codemod-optional-catch-binding
➤ YN0000: eslint/babel-eslint-config-internal
➤ YN0000: eslint/babel-eslint-parser
➤ YN0000: eslint/babel-eslint-plugin
➤ YN0000: eslint/babel-eslint-plugin-development
➤ YN0000: eslint/babel-eslint-plugin-development-internal
➤ YN0000: eslint/babel-eslint-shared-fixtures
➤ YN0000: eslint/babel-eslint-tests
➤ YN0000: packages/babel-cli
➤ YN0000: packages/babel-code-frame
➤ YN0000: packages/babel-compat-data
➤ YN0000: packages/babel-core
➤ YN0000: packages/babel-generator
➤ YN0000: packages/babel-helper-annotate-as-pure
➤ YN0000: packages/babel-helper-bindify-decorators
➤ YN0000: packages/babel-helper-builder-binary-assignment-operator-visitor
➤ YN0000: packages/babel-helper-builder-react-jsx
➤ YN0000: packages/babel-helper-builder-react-jsx-experimental
➤ YN0000: packages/babel-helper-call-delegate
➤ YN0000: packages/babel-helper-compilation-targets
➤ YN0000: packages/babel-helper-create-class-features-plugin
➤ YN0000: packages/babel-helper-create-regexp-features-plugin
➤ YN0000: packages/babel-helper-define-map
➤ YN0000: packages/babel-helper-explode-assignable-expression
➤ YN0000: packages/babel-helper-explode-class
➤ YN0000: packages/babel-helper-fixtures
➤ YN0000: packages/babel-helper-function-name
➤ YN0000: packages/babel-helper-get-function-arity
➤ YN0000: packages/babel-helper-hoist-variables
➤ YN0000: packages/babel-helper-member-expression-to-functions
➤ YN0000: packages/babel-helper-module-imports
➤ YN0000: packages/babel-helper-module-transforms
➤ YN0000: packages/babel-helper-optimise-call-expression
➤ YN0000: packages/babel-helper-plugin-test-runner
➤ YN0000: packages/babel-helper-plugin-utils
➤ YN0000: packages/babel-helper-regex
➤ YN0000: packages/babel-helper-remap-async-to-generator
➤ YN0000: packages/babel-helper-replace-supers
➤ YN0000: packages/babel-helper-simple-access
➤ YN0000: packages/babel-helper-skip-transparent-expression-wrappers
➤ YN0000: packages/babel-helper-split-export-declaration
➤ YN0000: packages/babel-helper-transform-fixture-test-runner
➤ YN0000: packages/babel-helper-validator-identifier
➤ YN0000: packages/babel-helper-wrap-function
➤ YN0000: packages/babel-helpers
➤ YN0000: packages/babel-highlight
➤ YN0000: packages/babel-node
➤ YN0000: packages/babel-parser
➤ YN0000: packages/babel-plugin-external-helpers
➤ YN0000: packages/babel-plugin-proposal-async-generator-functions
➤ YN0000: packages/babel-plugin-proposal-class-properties
➤ YN0000: packages/babel-plugin-proposal-decorators
➤ YN0000: packages/babel-plugin-proposal-do-expressions
➤ YN0000: packages/babel-plugin-proposal-dynamic-import
➤ YN0000: packages/babel-plugin-proposal-export-default-from
➤ YN0000: packages/babel-plugin-proposal-export-namespace-from
➤ YN0000: packages/babel-plugin-proposal-function-bind
➤ YN0000: packages/babel-plugin-proposal-function-sent
➤ YN0000: packages/babel-plugin-proposal-json-strings
➤ YN0000: packages/babel-plugin-proposal-logical-assignment-operators
➤ YN0000: packages/babel-plugin-proposal-nullish-coalescing-operator
➤ YN0000: packages/babel-plugin-proposal-numeric-separator
➤ YN0000: packages/babel-plugin-proposal-object-rest-spread
➤ YN0000: packages/babel-plugin-proposal-optional-catch-binding
➤ YN0000: packages/babel-plugin-proposal-optional-chaining
➤ YN0000: packages/babel-plugin-proposal-partial-application
➤ YN0000: packages/babel-plugin-proposal-pipeline-operator
➤ YN0000: packages/babel-plugin-proposal-private-methods
➤ YN0000: packages/babel-plugin-proposal-private-property-in-object
➤ YN0000: packages/babel-plugin-proposal-throw-expressions
➤ YN0000: packages/babel-plugin-proposal-unicode-property-regex
➤ YN0000: packages/babel-plugin-syntax-class-properties
➤ YN0000: packages/babel-plugin-syntax-decimal
➤ YN0000: packages/babel-plugin-syntax-decorators
➤ YN0000: packages/babel-plugin-syntax-do-expressions
➤ YN0000: packages/babel-plugin-syntax-export-default-from
➤ YN0000: packages/babel-plugin-syntax-flow
➤ YN0000: packages/babel-plugin-syntax-function-bind
➤ YN0000: packages/babel-plugin-syntax-function-sent
➤ YN0000: packages/babel-plugin-syntax-import-meta
➤ YN0000: packages/babel-plugin-syntax-jsx
➤ YN0000: packages/babel-plugin-syntax-logical-assignment-operators
➤ YN0000: packages/babel-plugin-syntax-module-attributes
➤ YN0000: packages/babel-plugin-syntax-numeric-separator
➤ YN0000: packages/babel-plugin-syntax-partial-application
➤ YN0000: packages/babel-plugin-syntax-pipeline-operator
➤ YN0000: packages/babel-plugin-syntax-record-and-tuple
➤ YN0000: packages/babel-plugin-syntax-throw-expressions
➤ YN0000: packages/babel-plugin-syntax-top-level-await
➤ YN0000: packages/babel-plugin-syntax-typescript
➤ YN0000: packages/babel-plugin-transform-arrow-functions
➤ YN0000: packages/babel-plugin-transform-async-to-generator
➤ YN0000: packages/babel-plugin-transform-block-scoped-functions
➤ YN0000: packages/babel-plugin-transform-block-scoping
➤ YN0000: packages/babel-plugin-transform-classes
➤ YN0000: packages/babel-plugin-transform-computed-properties
➤ YN0000: packages/babel-plugin-transform-destructuring
➤ YN0000: packages/babel-plugin-transform-dotall-regex
➤ YN0000: packages/babel-plugin-transform-duplicate-keys
➤ YN0000: packages/babel-plugin-transform-exponentiation-operator
➤ YN0000: packages/babel-plugin-transform-flow-comments
➤ YN0000: packages/babel-plugin-transform-flow-strip-types
➤ YN0000: packages/babel-plugin-transform-for-of
➤ YN0000: packages/babel-plugin-transform-function-name
➤ YN0000: packages/babel-plugin-transform-instanceof
➤ YN0000: packages/babel-plugin-transform-jscript
➤ YN0000: packages/babel-plugin-transform-literals
➤ YN0000: packages/babel-plugin-transform-member-expression-literals
➤ YN0000: packages/babel-plugin-transform-modules-amd
➤ YN0000: packages/babel-plugin-transform-modules-commonjs
➤ YN0000: packages/babel-plugin-transform-modules-systemjs
➤ YN0000: packages/babel-plugin-transform-modules-umd
➤ YN0000: packages/babel-plugin-transform-named-capturing-groups-regex
➤ YN0000: packages/babel-plugin-transform-new-target
➤ YN0000: packages/babel-plugin-transform-object-assign
➤ YN0000: packages/babel-plugin-transform-object-set-prototype-of-to-assign
➤ YN0000: packages/babel-plugin-transform-object-super
➤ YN0000: packages/babel-plugin-transform-parameters
➤ YN0000: packages/babel-plugin-transform-property-literals
➤ YN0000: packages/babel-plugin-transform-property-mutators
➤ YN0000: packages/babel-plugin-transform-proto-to-assign
➤ YN0000: packages/babel-plugin-transform-react-constant-elements
➤ YN0000: packages/babel-plugin-transform-react-display-name
➤ YN0000: packages/babel-plugin-transform-react-inline-elements
➤ YN0000: packages/babel-plugin-transform-react-jsx
➤ YN0000: packages/babel-plugin-transform-react-jsx-compat
➤ YN0000: packages/babel-plugin-transform-react-jsx-development
➤ YN0000: packages/babel-plugin-transform-react-jsx-self
➤ YN0000: packages/babel-plugin-transform-react-jsx-source
➤ YN0000: packages/babel-plugin-transform-react-pure-annotations
➤ YN0000: packages/babel-plugin-transform-regenerator
➤ YN0000: packages/babel-plugin-transform-reserved-words
➤ YN0000: packages/babel-plugin-transform-runtime
➤ YN0000: packages/babel-plugin-transform-shorthand-properties
➤ YN0000: packages/babel-plugin-transform-spread
➤ YN0000: packages/babel-plugin-transform-sticky-regex
➤ YN0000: packages/babel-plugin-transform-strict-mode
➤ YN0000: packages/babel-plugin-transform-template-literals
➤ YN0000: packages/babel-plugin-transform-typeof-symbol
➤ YN0000: packages/babel-plugin-transform-typescript
➤ YN0000: packages/babel-plugin-transform-unicode-escapes
➤ YN0000: packages/babel-plugin-transform-unicode-regex
➤ YN0000: packages/babel-polyfill
➤ YN0000: packages/babel-preset-env
➤ YN0000: packages/babel-preset-flow
➤ YN0000: packages/babel-preset-react
➤ YN0000: packages/babel-preset-typescript
➤ YN0000: packages/babel-register
➤ YN0000: packages/babel-runtime
➤ YN0000: packages/babel-runtime-corejs2
➤ YN0000: packages/babel-runtime-corejs3
➤ YN0000: packages/babel-standalone
➤ YN0000: packages/babel-template
➤ YN0000: packages/babel-traverse
➤ YN0000: packages/babel-types
➤ YN0000: Done in 0s

@nicolo-ribaudo
Copy link
Member Author

@JLHwung The bug has not been introduced by #11777 (I can reproduce it even if I revert that commit)

@nicolo-ribaudo
Copy link
Member Author

I give up for today, I'll properly bisect.

@JLHwung
Copy link
Contributor

JLHwung commented Aug 14, 2020

I can still reproduce the e2e error if we replace workspace:\^7\.\d+\.\d+ to workspace:*, which is also recommended in the docs.

@arcanis
Copy link
Contributor

arcanis commented Aug 15, 2020

Found the problem! There's an accidental lockfile (I think?) in eslint/babel-eslint-parser/yarn.lock that throws off Yarn when running yarn pack inside this folder - preventing it from detecting other workspaces.

@JLHwung
Copy link
Contributor

JLHwung commented Aug 15, 2020

The e2e error has been fixed in #11962.

@nicolo-ribaudo
Copy link
Member Author

Closing, I'll do this again after the yarn PRs are merged into main.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet