Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure defaults are set in @babel/eslint-parser #11970

Merged
merged 3 commits into from Aug 19, 2020

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Aug 17, 2020

Q                       A
Fixed Issues? Fixes #11902
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

ESLint sets ecmaVersion: undefined in the config options passed to custom parsers when the ecmaVersion isn't defined in the user's config. Since the key exists, it ends up overriding the default value :(

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 41df4ed:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Aug 17, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27565/

@JLHwung JLHwung added this to the 7.11.4 milestone Aug 18, 2020
@JLHwung JLHwung added area: eslint PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Aug 18, 2020
@JLHwung JLHwung merged commit 180e9c0 into babel:main Aug 19, 2020
@kaicataldo kaicataldo deleted the babel-eslint-parser-defaults branch August 19, 2020 01:32
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: eslint outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@babel/eslint-parser does not have default parserOptions (but babel-eslint did)
4 participants