Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure CI workflow #12002

Merged
merged 5 commits into from Aug 26, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
50 changes: 44 additions & 6 deletions .github/workflows/ci.yml
Expand Up @@ -25,7 +25,7 @@ jobs:
if: steps.yarn-cache.outputs.cache-hit != 'true'
env:
YARN_ENABLE_SCRIPTS: false # disable post-install scripts
YARN_NODE_LINKER: pnp # use pnp linker for better performance: it meant to update yarn cache only
YARN_NODE_LINKER: pnp # use pnp linker for better performance: it's meant to update yarn cache only
run: |
yarn install --immutable

Expand Down Expand Up @@ -53,13 +53,45 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

legacy-node-version-test:
name: Test on Node.js
build:
name: Build Babel Artifacts
needs: prepare-yarn-cache
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Use Node.js latest
uses: actions/setup-node@v2-beta
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
- uses: actions/cache@v2
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- name: Build babel artifacts
run: |
BABEL_ENV=test-legacy make -j build-standalone-ci
- uses: actions/upload-artifact@v2
with:
name: babel-artifact
path: |
codemods/*/lib/**/*
eslint/*/lib/**/*
packages/*/lib/**/*
packages/babel-polyfill/dist/**/*
packages/babel-standalone/*.js
!**/node_modules/**

test:
name: Test on Node.js # GitHub will add ${{ matrix.node-version }} to this title
needs: build
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [6.x, 8.x]
node-version: [13, 12, 10, 8, 6]
steps:
- name: Checkout code
uses: actions/checkout@v2
Expand All @@ -72,9 +104,15 @@ jobs:
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }}
- name: Build
- name: Install
run: |
BABEL_ENV=test-legacy make -j bootstrap-only
- uses: actions/download-artifact@v2
with:
name: babel-artifact
- name: Generate runtime helpers
run: |
BABEL_ENV=test-legacy make -j bootstrap
make build-plugin-transform-runtime-dist
Copy link
Contributor Author

@JLHwung JLHwung Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is moved to test executor (instead of the Build job) because it is IO-intensive (1000 files), caching and restoring are slower than generating.

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2-beta
with:
Expand Down
4 changes: 0 additions & 4 deletions .travis.yml
Expand Up @@ -30,7 +30,6 @@ matrix:
- node_js: "node"
env: JOB=lint
# We test the latest version on circleci
- node_js: "13"
# Move `windows` build to be the third since it is slow
- os: windows
node_js: "node"
Expand All @@ -43,9 +42,6 @@ matrix:
directories:
- $HOME/AppData/Local/Temp/chocolatey
- $HOME/AppData/Local/Yarn/Berry/cache
# Continue node_js matrix
- node_js: "12"
- node_js: "10"
- node_js: "node"
env: JOB=babel-parser-flow-tests
- node_js: "node"
Expand Down