Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #12014 #12027

Merged
merged 2 commits into from Sep 1, 2020
Merged

Revert #12014 #12027

merged 2 commits into from Sep 1, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 1, 2020

Q                       A
Fixed Issues? Fixes #12025
Patch: Bug Fix? Yes
Any Dependency Changes? source-map is downgraded
License MIT

Revert #12014 where source-map@0.6 includes mozilla/source-map#265 that throws when there is JS comments in the input code. Before mozilla/source-map#385 is resolved, we have to pin the source-map versions.

@JLHwung JLHwung added i: regression pkg: core PR: Revert ↩️ A type of pull request used for our changelog categories labels Sep 1, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28210/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f331935:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung merged commit a91fdeb into babel:main Sep 1, 2020
@JLHwung JLHwung deleted the fix-12025 branch September 1, 2020 19:42
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: core PR: Revert ↩️ A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Error: original.line and original.column are not numbers" after upgrading to 7.11.5
4 participants