Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use latest node on ci workflow when possible #12049

Merged
merged 1 commit into from Sep 10, 2020
Merged

chore: use latest node on ci workflow when possible #12049

merged 1 commit into from Sep 10, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 9, 2020 •
edited

Q                       A
License MIT

This PR partially reverts change implemented in #11952 where node-version is removed.

/cc @fisker

Per actions/setup-node docs

The node-version input is optional. If not supplied, node which is in your PATH will be used.

Currently, when node-version is not set, it refers to v12 LTS: https://github.com/JLHwung/babel/runs/1093487909#step:6:8

When node-version is set to *, it refers to v14: https://github.com/babel/babel/pull/12049/checks?check_run_id=1093534529#step:3:7

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 9, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Sep 9, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28350/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 67dfeef:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@fisker
Copy link
Contributor

fisker commented Sep 10, 2020

Didn't notice this difference. 👍

@JLHwung
Copy link
Contributor Author

JLHwung commented Sep 10, 2020

I am merging with one approval since it does not change the codebase and @fisker has reviewed.

@JLHwung JLHwung merged commit c8f0b6d into babel:main Sep 10, 2020
@JLHwung JLHwung deleted the use-latest-node-on-github-ci branch September 10, 2020 21:33
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @fisker @existentialism