Ensure expressions wrapped in parens #12082
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #12055.
The fix itself is very simple. I've added tests for the original bug and also some other weird cases which were previously producing incorrect output.
I am assuming that existing behavior for standalone expressions is correct.
i.e.
generate( t.objectExpression([]) ).code
should produce{}
not({})
. Certainly that's what I want it to be!One case produces excess parentheses:
This generates
() => (({}), 1)
. I couldn't see a way to avoid this without introducing excess complexity for a pretty uncommon case.Please shout if you want any changes.