Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw a recoverable error for missing initializer in const declaration #12120

Merged
merged 1 commit into from Sep 29, 2020
Merged

Throw a recoverable error for missing initializer in const declaration #12120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/babel-parser/src/parser/statement.js
View file
Open in desktop
Expand Up @@ -1016,7 +1016,11 @@ export default class StatementParser extends ExpressionParser {
// `const` with no initializer is allowed in TypeScript.
// It could be a declaration like `const x: number;`.
if (!isTypescript) {
this.unexpected();
this.raise(
this.state.lastTokEnd,
Errors.DeclarationMissingInitializer,
"Const declarations",
);
}
} else if (
decl.id.type !== "Identifier" &&
Expand Down
3 changes: 0 additions & 3 deletions packages/babel-parser/test/fixtures/core/uncategorised/536/options.json
View file
Open in desktop

This file was deleted.

33 changes: 33 additions & 0 deletions packages/babel-parser/test/fixtures/core/uncategorised/536/output.json
View file
Open in desktop
@@ -0,0 +1,33 @@
{
"type": "File",
"start":0,"end":8,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":8}},
"errors": [
"SyntaxError: Const declarations require an initialization value (1:7)"
],
"program": {
"type": "Program",
"start":0,"end":8,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":8}},
"sourceType": "script",
"interpreter": null,
"body": [
{
"type": "VariableDeclaration",
"start":0,"end":8,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":8}},
"declarations": [
{
"type": "VariableDeclarator",
"start":6,"end":7,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":7}},
"id": {
"type": "Identifier",
"start":6,"end":7,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":7},"identifierName":"a"},
"name": "a"
},
"init": null
}
],
"kind": "const"
}
],
"directives": []
}
}
4 changes: 2 additions & 2 deletions packages/babel-parser/test/fixtures/esprima/es2015-for-of/unexpected-number/options.json
View file
Open in desktop
@@ -1,3 +1,3 @@
{
"throws": "Unexpected token (1:14)"
}
"throws": "Unexpected token, expected \";\" (1:14)"
}
3 changes: 0 additions & 3 deletions packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0138/options.json
View file
Open in desktop

This file was deleted.

51 changes: 51 additions & 0 deletions packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0138/output.json
View file
Open in desktop
@@ -0,0 +1,51 @@
{
"type": "File",
"start":0,"end":16,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":16}},
"errors": [
"SyntaxError: Const declarations require an initialization value (1:15)"
],
"program": {
"type": "Program",
"start":0,"end":16,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":16}},
"sourceType": "script",
"interpreter": null,
"body": [
{
"type": "VariableDeclaration",
"start":0,"end":16,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":16}},
"declarations": [
{
"type": "VariableDeclarator",
"start":6,"end":12,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":12}},
"id": {
"type": "Identifier",
"start":6,"end":7,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":7},"identifierName":"x"},
"name": "x"
},
"init": {
"type": "NumericLiteral",
"start":10,"end":12,"loc":{"start":{"line":1,"column":10},"end":{"line":1,"column":12}},
"extra": {
"rawValue": 12,
"raw": "12"
},
"value": 12
}
},
{
"type": "VariableDeclarator",
"start":14,"end":15,"loc":{"start":{"line":1,"column":14},"end":{"line":1,"column":15}},
"id": {
"type": "Identifier",
"start":14,"end":15,"loc":{"start":{"line":1,"column":14},"end":{"line":1,"column":15},"identifierName":"y"},
"name": "y"
},
"init": null
}
],
"kind": "const"
}
],
"directives": []
}
}
3 changes: 0 additions & 3 deletions packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0139/options.json
View file
Open in desktop

This file was deleted.

51 changes: 51 additions & 0 deletions packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0139/output.json
View file
Open in desktop
@@ -0,0 +1,51 @@
{
"type": "File",
"start":0,"end":16,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":16}},
"errors": [
"SyntaxError: Const declarations require an initialization value (1:7)"
],
"program": {
"type": "Program",
"start":0,"end":16,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":16}},
"sourceType": "script",
"interpreter": null,
"body": [
{
"type": "VariableDeclaration",
"start":0,"end":16,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":16}},
"declarations": [
{
"type": "VariableDeclarator",
"start":6,"end":7,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":7}},
"id": {
"type": "Identifier",
"start":6,"end":7,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":7},"identifierName":"x"},
"name": "x"
},
"init": null
},
{
"type": "VariableDeclarator",
"start":9,"end":15,"loc":{"start":{"line":1,"column":9},"end":{"line":1,"column":15}},
"id": {
"type": "Identifier",
"start":9,"end":10,"loc":{"start":{"line":1,"column":9},"end":{"line":1,"column":10},"identifierName":"y"},
"name": "y"
},
"init": {
"type": "NumericLiteral",
"start":13,"end":15,"loc":{"start":{"line":1,"column":13},"end":{"line":1,"column":15}},
"extra": {
"rawValue": 12,
"raw": "12"
},
"value": 12
}
}
],
"kind": "const"
}
],
"directives": []
}
}
3 changes: 0 additions & 3 deletions packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0140/options.json
View file
Open in desktop

This file was deleted.

33 changes: 33 additions & 0 deletions packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0140/output.json
View file
Open in desktop
@@ -0,0 +1,33 @@
{
"type": "File",
"start":0,"end":8,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":8}},
"errors": [
"SyntaxError: Const declarations require an initialization value (1:7)"
],
"program": {
"type": "Program",
"start":0,"end":8,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":8}},
"sourceType": "script",
"interpreter": null,
"body": [
{
"type": "VariableDeclaration",
"start":0,"end":8,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":8}},
"declarations": [
{
"type": "VariableDeclarator",
"start":6,"end":7,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":7}},
"id": {
"type": "Identifier",
"start":6,"end":7,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":7},"identifierName":"x"},
"name": "x"
},
"init": null
}
],
"kind": "const"
}
],
"directives": []
}
}