Yarn 2.3

[nicolo-ribaudo]

Q	A
Fixed Issues?	Fixes #12125
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?	Removed @yarn/plugin-duplicates
License	MIT

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29237/

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e118831:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

[nicolo-ribaudo]

@arcanis / @larixer I think there is an hoisting bug: @babel/cli has a devDependency on @babel/core@workspace:^7.11.6, but if I run yarn after updating to 2.3 then

• ./packages/babel-cli/node_modules doesn't contain @babel/core
• ./node_modules/@babel/core is the version from npm and not the local one.

So @babel/cli doesn't find the correct @babel/core.

[JLHwung]

We should force publish all packages in e2e test so we are sure that in every commit all packages are publishable. It helps evaluate whether an yarn upgrade will break some package (but not published due to not changed in certain PR).

[nicolo-ribaudo]

Note that the failing e2e test is not a Babel bug, it's only failing because of the wrong resolved @babel/core.

[arcanis]

We're going to look into it and publish a patch fix if necessary.

We're currently running Babel installs for every change to the NM linker, but we don't try to pack them. How much time does it usually take? If it's ~15mns max it's something we can consider adding to our testsuite 🤔

[nicolo-ribaudo]

Our main e2e test (publish + test) takes about 10 mins: https://app.circleci.com/pipelines/github/babel/babel/3987/workflows/12f7ebbe-a212-4372-96ec-7646dbff15df/jobs/29162 + https://app.circleci.com/pipelines/github/babel/babel/3987/workflows/12f7ebbe-a212-4372-96ec-7646dbff15df/jobs/29165. However, this bug wouldn't have been caught because it is only "detected" when testing @babel/cli with an old version of @babel/core as a top-level dependency (we do this in a different e2e test).

[arcanis]

However, this bug wouldn't have been caught because it is only "detected" when testing @babel/cli with an old version of @babel/core as a top-level dependency (we do this in our e2e tests).

Actually we run a diagnostic pass after install, so our tests should have been enough even without packing. Thankfully we just discovered why they didn't catch this problem earlier: we're still cloning the old next-8-dev branch, which doesn't have the problematic dependency pattern 😅

[arcanis]

Can you check with the 2.3.1?

[JLHwung]