New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "extensions" option in config files and presets #12151
Closed
nicolo-ribaudo
wants to merge
4
commits into
babel:feat-7.12.0/config-loading-updates
from
nicolo-ribaudo:extensions-in-config
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
61ec0ec
Add "extensions" option
nicolo-ribaudo af19c05
Use the new "extensions" option in @babel/register
nicolo-ribaudo 2387ea7
Fix @babel/cli's copying logic by resolving "extensions" in @babel/core
nicolo-ribaudo 1acae43
Define "extensions" in @babel/preset-typescript
nicolo-ribaudo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
...l-cli/test/fixtures/babel/dir uses extensions from config file/in-files/src/.babelrc.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"extensions": [".tsx"] | ||
} |
1 change: 1 addition & 0 deletions
1
...es/babel-cli/test/fixtures/babel/dir uses extensions from config file/in-files/src/bar.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
x; |
1 change: 1 addition & 0 deletions
1
...es/babel-cli/test/fixtures/babel/dir uses extensions from config file/in-files/src/baz.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
x; |
1 change: 1 addition & 0 deletions
1
...s/babel-cli/test/fixtures/babel/dir uses extensions from config file/in-files/src/foo.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
x; |
3 changes: 3 additions & 0 deletions
3
packages/babel-cli/test/fixtures/babel/dir uses extensions from config file/options.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"args": ["src", "--out-dir", "lib"] | ||
} |
3 changes: 3 additions & 0 deletions
3
...s/babel-cli/test/fixtures/babel/dir uses extensions from config file/out-files/lib/baz.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
|
||
x; |
3 changes: 3 additions & 0 deletions
3
...s/babel-cli/test/fixtures/babel/dir uses extensions from config file/out-files/lib/foo.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
|
||
x; |
1 change: 1 addition & 0 deletions
1
packages/babel-cli/test/fixtures/babel/dir uses extensions from config file/stdout.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Successfully compiled 2 files with Babel (123ms). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ import gensync, { type Handler } from "gensync"; | |
import { forwardAsync } from "../gensync-utils/async"; | ||
|
||
import { mergeOptions } from "./util"; | ||
import * as context from "../index"; | ||
import * as babelContext from "../index"; | ||
import Plugin from "./plugin"; | ||
import { getItemDescriptor } from "./item"; | ||
import { | ||
|
@@ -70,7 +70,7 @@ export default gensync<[any], ResolvedConfig | null>(function* loadFullConfig( | |
return null; | ||
} | ||
|
||
const optionDefaults = {}; | ||
const optionDefaults: ValidatedOptions = {}; | ||
|
||
const { plugins, presets } = options; | ||
|
||
|
@@ -161,6 +161,8 @@ export default gensync<[any], ResolvedConfig | null>(function* loadFullConfig( | |
const opts: Object = optionDefaults; | ||
mergeOptions(opts, options); | ||
|
||
if (!isCompilableFile(context.filename, opts.extensions)) return null; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
yield* enhanceError(context, function* loadPluginDescriptors() { | ||
pluginDescriptorsByPass[0].unshift(...initialPluginsDescriptors); | ||
|
||
|
@@ -229,7 +231,7 @@ const loadDescriptor = makeWeakCache(function* ( | |
let item = value; | ||
if (typeof value === "function") { | ||
const api = { | ||
...context, | ||
...babelContext, | ||
...makeAPI(cache), | ||
}; | ||
try { | ||
|
@@ -395,3 +397,8 @@ function chain(a, b) { | |
} | ||
}; | ||
} | ||
|
||
function isCompilableFile(filename, extensions) { | ||
if (filename == null) return true; | ||
return extensions.some(ext => ext === "*" || filename.endsWith(ext)); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new-version
inMakefile
to replace 7.11 with the actual new version.