New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix arrow transformation when arguments
is defined as variable
#12344
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
9 changes: 9 additions & 0 deletions
9
...nsform-arrow-functions/test/fixtures/arrow-functions/arguments-global-undeclared/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
function fn() { | ||
var foo = () => { | ||
return arguments; | ||
}; | ||
} | ||
|
||
var bar = () => arguments; | ||
|
||
var baz = () => () => arguments; |
19 changes: 19 additions & 0 deletions
19
...sform-arrow-functions/test/fixtures/arrow-functions/arguments-global-undeclared/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
var _arguments2 = typeof arguments === "undefined" ? void 0 : arguments; | ||
|
||
function fn() { | ||
var _arguments = arguments; | ||
|
||
var foo = function () { | ||
return _arguments; | ||
}; | ||
} | ||
|
||
var bar = function () { | ||
return _arguments2; | ||
}; | ||
|
||
var baz = function () { | ||
return function () { | ||
return _arguments2; | ||
}; | ||
}; |
10 changes: 10 additions & 0 deletions
10
...gin-transform-arrow-functions/test/fixtures/arrow-functions/arguments-global-var/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
var arguments = 1; | ||
function fn() { | ||
var foo = () => { | ||
return arguments; | ||
}; | ||
} | ||
|
||
var bar = () => arguments; | ||
|
||
var baz = () => () => arguments; |
19 changes: 19 additions & 0 deletions
19
...in-transform-arrow-functions/test/fixtures/arrow-functions/arguments-global-var/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
var _arguments2 = 1; | ||
|
||
function fn() { | ||
var _arguments = _arguments2; | ||
|
||
var foo = function () { | ||
return _arguments; | ||
}; | ||
} | ||
|
||
var bar = function () { | ||
return _arguments2; | ||
}; | ||
|
||
var baz = function () { | ||
return function () { | ||
return _arguments2; | ||
}; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this code to avoid the error described in #7673. It still isn't 100% correct since sometimes it doesn't throw the error if
arguments
is undeclared, but at least it doesn't throw for valid code.