Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prompt maintainer to quit make watch before publish #12357

Merged
merged 2 commits into from Nov 14, 2020
Merged

chore: prompt maintainer to quit make watch before publish #12357

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1f1690
chore: prompt maintainer to quit make watch before publish
JLHwung Nov 13, 2020
f47e4c6
move shell prompt to Makefile
JLHwung Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions Makefile
View file
Open in desktop
Expand Up @@ -243,9 +243,8 @@ new-version:
$(YARN) release-tool version $(FORCE_PUBLISH)

# NOTE: Run make new-version first
publish: prepublish
$(YARN) release-tool publish
$(MAKE) clean
publish:
bash ./scripts/publish.sh

check-yarn-bug-1882:
ifneq ("$(shell grep 3155328e5 .yarn/releases/yarn-*.cjs -c)", "0")
Expand Down
11 changes: 11 additions & 0 deletions scripts/publish.sh
View file
Open in desktop
@@ -0,0 +1,11 @@
#!/bin/bash

echo "Please confirm you have stopped \`make watch\`. (y)es, [N]o: "

read CLEAR;

if [ "_$CLEAR" == "_y" ]; then
make prepublish
yarn release-tool publish
make clean
JLHwung marked this conversation as resolved.
Show resolved Hide resolved
fi