Initialize NodePath context when using getSibling
#12387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
path
returned byNodePath.get()
is passed back to plugins code, we must make sure to always initialize thecontext
(otherwise it re-uses a possibly wrong cached contex).I'm marking this PR as
i: regression
even if this bug was already present, because #12331 made it more common (noScope: true
was almost ignored before that PR, while after that PR it's respected).