Requeue parent path after processing optionals

[existentialism]

Q	A
Fixed Issues?	Fixes #12386
Patch: Bug Fix?	Y
License	MIT

[JLHwung]

Not a blocker, but we should figure out why the test passes without requeuing parent path on @babel/traverse 7.12.3.

[existentialism]

For sure, in the middle of digging actually

[existentialism]

It looks like: #12302, still digging

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 26c522e:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

[nicolo-ribaudo]

I think we should requeue replacementPath and not parentPath, since they are not always the same thing.

[existentialism]

That was my first thought too, but there's some non obvious thing going on, still digging further.

[nicolo-ribaudo]

Oh ok. Do you think that it's better to merge this PR since "it works", and then revisit for another release? Or should we wait?

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33121/

[nicolo-ribaudo]

Please wait for merging this PR, I might have a fix that handles this at the NodePath level.

[luispedro18]

Please wait for merging this PR, I might have a fix that handles this at the NodePath level.

Hey @nicolo-ribaudo and @existentialism ... the fix at NodePath level might fix the issues that were raised but doesn't still fully fix another issue I'm having which this PR fixes ...

const findAttribute = (selectedProduct, identifier, valueId) =>
    selectedProduct?.allLevelsProductAttributes?.find(attribute => {
        return attribute?.identifier === identifier && attribute.values?.[0]?.identifier === valueId;
    });

If you put this piece of code on REPL of this build it's fine but if you put the exact same code on latest version REPL it still has some optional chaining that was not correctly transpiled.. Thoughts?

[nicolo-ribaudo]

Sorry, I didn't open my PR yet 😅

I think that the problem I found while investigating and #12391 are two different bugs that can both cause this incorrect output (from my experiments, fixing one of them is enough to fix the optional chaining thing).

It seems like #12391 fixes your example: https://babeljs.io/repl/build/33151/#?browsers=chrome%2070&build=&builtIns=usage&spec=false&loose=false&code_lz=MYewdgzgLgBAZgSzAEwIJSgJwQIwK5QCmMAvDABQSEA2hwRyACpiMnvQDQwLKFhQJEhTFwBuAQ2p5CASWQBKUgD4AUDHUwqteoSYs29APwA6SdQAyhUTQjNW7KOiy4ChCCcQpy4jNnxFlGABvNQ0wzEIoPEwwGB9nf0ITHj4BIUxSEjIU_kEEYRgAMkK43xciYwkpNxMAbQAGAF1k3lz0zLIq6TkAblD1AF95HqA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=true&fileSize=false&timeTravel=false&sourceType=module&lineWrap=false&presets=env&prettier=false&targets=&version=7.12.7%2Bpr.12391&externalPlugins=

[luispedro18]

Ahhh, misunderstood the nodePath fix then.. I saw in the latest changelog that a bug related with nodePath was fixed and thought that was the one... Sorry, my bad! 😅
And yes, #12391 seems to fix my issue.. Thanks for the quick reply 🙌

[nicolo-ribaudo]

Fixed in 7.12.9