New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
babel-types update OptionalCallExpression to support ArgumentPlaceholder #12418
babel-types update OptionalCallExpression to support ArgumentPlaceholder #12418
Conversation
Thanks! Could you run |
sure, forgot about that when cherrypicking it |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33593/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b15a5d3:
|
Ref: tc39/proposal-partial-application#35 This is not specified as valid syntax in the proposal, but we are currently accepting it and it aligns with the opinion of the proposal author. |
it looks to be not required - changes are only it generated typing files, which are not in git |
Oh right, I didn't notice that it's just changing the accepted types. |
@zxbodya Did you push the generated typings? |
it is only for files in |
Adding support for
ArgumentPlaceholder
inOptionalCallExpression
to align it withCallExpression
.Found this while rebasing #11578