Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cloneNode(deep, withoutLoc) handles absent comments #12602

Merged
merged 1 commit into from Jan 13, 2021

Conversation

FauxFaux
Copy link
Contributor

@FauxFaux FauxFaux commented Jan 10, 2021

Q                       A
Fixed Issues? This one. 😄
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link No
Any Dependency Changes? No
License MIT

This fragment (maybe all fragments?) throw during cloneNode() with deep and withoutLoc.

foo();

comments is unset here. Handle it being unset, by passing through the undefined.

@babel-bot
Copy link
Collaborator

babel-bot commented Jan 10, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/37189/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 10, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f21a48b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo
Copy link
Member

Can you modify maybeCloneComments to return deep && withoutLoc && comments ? cloneCommentsWithoutLoc(comments) : comments instead?

And also if you know TS please add type annotations to maybeCloneComments's params, so that it's clear that comments might be absent 🙏

@nicolo-ribaudo nicolo-ribaudo added pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jan 10, 2021
This fragment (maybe all fragments?) throw during cloning, as
'comments' is unset here. Handle it being unset, by returning
undefined.
@FauxFaux
Copy link
Contributor Author

Done.

@FauxFaux FauxFaux marked this pull request as ready for review January 11, 2021 05:57
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung merged commit bd4590e into babel:main Jan 13, 2021
@FauxFaux FauxFaux deleted the fix/clone-fragments branch January 13, 2021 05:48
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants