New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cloneNode(deep, withoutLoc) handles absent comments #12602
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/37189/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f21a48b:
|
Can you modify And also if you know TS please add type annotations to |
This fragment (maybe all fragments?) throw during cloning, as 'comments' is unset here. Handle it being unset, by returning undefined.
a95f58f
to
f21a48b
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This fragment (maybe all fragments?) throw during
cloneNode()
withdeep
andwithoutLoc
.comments
is unset here. Handle it being unset, by passing through theundefined
.