Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn-plugin-conditions to update Babel 8 dependencies #12655

Closed

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jan 19, 2021

Q                       A
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This is a follow-up to #12440. In that PR I wrote

With this PR, it would be possible to inline many breaking changes (everything except for dependency updates) directly in main

but we would still need to use a next-8-dev branch for every change affecting package.json files, such as 5b3ca43. It's surely easier to merge/rebase than the complete next-8-dev branch we had before the BABEL_8_BREAKING flag, but it still requires some additional work.

With this PR, we can also start using the BABEL_8_BREAKING flag in package.json files, to move all the Babel 8 updates to main.

The yarn plugin source, if you are interested: https://github.com/nicolo-ribaudo/yarn-plugin-conditions

When CI of #12656 finishes, I'll post here the published package.json files so that you can see that the Yarn plugin works.

@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jan 19, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 803efce:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Jan 19, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/37841/

@nicolo-ribaudo nicolo-ribaudo force-pushed the yarn-plugin-conditions branch 2 times, most recently from dd76844 to 1e2cfbd Compare January 19, 2021 01:22
@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Jan 19, 2021

package.json published for @babel/cli in the e2e tests:

{
  "name": "@babel/cli",
  "version": "7.12.13",
  "description": "Babel command line.",
  "author": "Sebastian McKenzie <sebmck@gmail.com>",
  "homepage": "https://babel.dev/docs/en/next/babel-cli",
  "bugs": "https://github.com/babel/babel/issues?utf8=%E2%9C%93&q=is%3Aissue+label%3A%22pkg%3A%20cli%22+is%3Aopen",
  "license": "MIT",
  "publishConfig": {
    "access": "public"
  },
  "repository": {
    "type": "git",
    "url": "https://github.com/babel/babel.git",
    "directory": "packages/babel-cli"
  },
  "keywords": [
    "6to5",
    "babel",
    "es6",
    "transpile",
    "transpiler",
    "babel-cli",
    "compiler"
  ],
  "dependencies": {
    "commander": "^4.0.1",
    "convert-source-map": "^1.1.0",
    "fs-readdir-recursive": "^1.1.0",
    "glob": "^7.0.0",
    "lodash": "^4.17.19",
    "make-dir": "^2.1.0",
    "slash": "^2.0.0",
    "source-map": "^0.5.0"
  },
  "optionalDependencies": {
    "@nicolo-ribaudo/chokidar-2": "2.1.8-no-fsevents",
    "chokidar": "^3.4.0"
  },
  "peerDependencies": {
    "@babel/core": "^7.0.0-0"
  },
  "devDependencies": {
    "@babel/core": "7.12.13",
    "@babel/helper-fixtures": "7.12.13",
    "rimraf": "^3.0.0"
  },
  "bin": {
    "babel": "./bin/babel.js",
    "babel-external-helpers": "./bin/babel-external-helpers.js"
  }
}

package.json published for @babel/cli in the e2e-breaking tests: (note that the slash version changed)

{
  "name": "@babel/cli",
  "version": "7.12.13",
  "description": "Babel command line.",
  "author": "Sebastian McKenzie <sebmck@gmail.com>",
  "homepage": "https://babel.dev/docs/en/next/babel-cli",
  "bugs": "https://github.com/babel/babel/issues?utf8=%E2%9C%93&q=is%3Aissue+label%3A%22pkg%3A%20cli%22+is%3Aopen",
  "license": "MIT",
  "publishConfig": {
    "access": "public"
  },
  "repository": {
    "type": "git",
    "url": "https://github.com/babel/babel.git",
    "directory": "packages/babel-cli"
  },
  "keywords": [
    "6to5",
    "babel",
    "es6",
    "transpile",
    "transpiler",
    "babel-cli",
    "compiler"
  ],
  "dependencies": {
    "commander": "^4.0.1",
    "convert-source-map": "^1.1.0",
    "fs-readdir-recursive": "^1.1.0",
    "glob": "^7.0.0",
    "lodash": "^4.17.19",
    "make-dir": "^2.1.0",
    "slash": "^3.0.0",
    "source-map": "^0.5.0"
  },
  "optionalDependencies": {
    "@nicolo-ribaudo/chokidar-2": "2.1.8-no-fsevents",
    "chokidar": "^3.4.0"
  },
  "peerDependencies": {
    "@babel/core": "^7.0.0-0"
  },
  "devDependencies": {
    "@babel/core": "7.12.13",
    "@babel/helper-fixtures": "7.12.13",
    "rimraf": "^3.0.0"
  },
  "bin": {
    "babel": "./bin/babel.js",
    "babel-external-helpers": "./bin/babel-external-helpers.js"
  }
}

@nicolo-ribaudo nicolo-ribaudo marked this pull request as draft January 19, 2021 02:31
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants